-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(auth): Add recaptcha and sms toll fraud support for phone auth #2625
base: master
Are you sure you want to change the base?
Conversation
src/auth/auth-config.ts
Outdated
*/ | ||
export interface RecaptchaTollFraudManagedRule { | ||
/** | ||
* The action will be enforced if the reCAPTCHA score of a request is larger than endScore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be startScore
instead of endScore
in the doc? Also should we mention the range of values that is allowed and add that into our validation logic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
useAccountDefender?: boolean; | ||
useSmsBotScore?: boolean; | ||
useSmsTollFraudProtection?: boolean; | ||
tollFraudManagedRules?: RecaptchaTollFraudManagedRule[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a discrepancy between rpc request and response field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the rpc request address the field as tollFraudManagedRules
and SDK exposes it as smsTollFraudManagedRules
No description provided.