[FDL deprecation #1] Added mobileLinksConfig field for project and tenant configs #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…updating workflow. This will be later used in Firebase Dynamic links deprecation work.
pragatimodi
reviewed
Sep 4, 2024
| @@ -51,6 +51,18 @@ describe('ProjectConfig', () => { | |||
| }, | |||
| ], | |||
| }, | |||
| recaptchaConfig: { | |||
There was a problem hiding this comment.
Do we need this?
updateProjectConfigRequest3 already has the same update config for recaptcha and I believe we are testing that functionality?
pragatimodi
reviewed
Sep 4, 2024
| @@ -490,6 +524,7 @@ describe('ProjectConfig', () => { | |||
| it('should set readonly property multiFactorConfig', () => { | |||
| const expectedMultiFactorConfig = { | |||
| state: 'DISABLED', | |||
| factorIds: [], | |||
There was a problem hiding this comment.
Is this required when state is DISABLED?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added mobileLinksConfig field for project and tenant creation and/or updating workflows.
This will be later used in Firebase Dynamic links deprecation work.
Fixed some legacy failing tests.
fdl-deprecation. Later when launched,fdl-deprecationwill be merged intomasterbranch.