Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR][FCM] HTTP2 support for sendEach #788

Open
Klemenceo opened this issue May 10, 2024 · 11 comments
Open

[FR][FCM] HTTP2 support for sendEach #788

Klemenceo opened this issue May 10, 2024 · 11 comments

Comments

@Klemenceo
Copy link

Klemenceo commented May 10, 2024

Hello,

With the new FCM v1 http endpoints, support for batching was removed. The solution for large volume is now topics (but that leave you with generic messages) and using HTTP2 (just like APNs does) to benefit from multiplexing.

The current implementation uses requests, which doesn't support HTTP2, and uses a ThreadPool as a means of doing concurrent sends, but you still pay for the HTTP layer on each send.

Are there plan to use something like hyperx in the future to switch sendEach to, in order to benefit from http2 multiplexing.

Thanks in advance.

@google-oss-bot
Copy link

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@davidemerritt
Copy link

+1 - this has a pretty urgent timeline with the june 20th deprecation of the existing batch send.

@jonathanedey
Copy link
Contributor

Hi Folks,
We are aware of these issues and working to address them.

Currently, support for HTTP/2 in Node.js is underway and our next focus is exploring similar options for Java, Python and the remaining SDKs. We will use this issue to track any progress here.

We can't provide a timeline for the completion of these projects but we are working to have these resolved as soon as we can and appreciate your continued patience as we do so.

@davidemerritt
Copy link

Will this be resolved prior to the june 20th cutoff for existing legacy endpoints? This swapover doesn't provide a reasonable migration strategy without this being implemented.

@Tom3652
Copy link

Tom3652 commented May 20, 2024

I was going to make the same feature request, glad this is a known issue 🙏🏼

@jagerman
Copy link

jagerman commented Jun 20, 2024

+1 - this has a pretty urgent timeline with the june 20th deprecation of the existing batch send.

Thankfully Google heard the cries of developers of every single firebase-admin-xyz repository pointing out the problems with the migration and came up with a working solution before the deadline. (Edit: this is sarcasm).

@jhkim-grip
Copy link

jhkim-grip commented Jul 3, 2024

+1 - this has a pretty urgent timeline with the june 20th deprecation of the existing batch send.

Thankfully Google heard the cries of developers of every single firebase-admin-xyz repository pointing out the problems with the migration and came up with a working solution before the deadline.

@jagerman may i ask what solution is that? i can't find it

@jagerman
Copy link

jagerman commented Jul 7, 2024

@jagerman may i ask what solution is that? i can't find it

That was sarcasm. As for an actual solution, https://github.com/olucurious/pyfcm is probably the option as Google apparently isn't interested it maintaining their tools.

@vivekshah1801
Copy link

vivekshah1801 commented Jul 22, 2024

I was going to create the same FR.

@dpereiraegoi
Copy link

Any updates?

@Jay2109
Copy link

Jay2109 commented Sep 24, 2024

@jagerman may i ask what solution is that? i can't find it

That was sarcasm. As for an actual solution, https://github.com/olucurious/pyfcm is probably the option as Google apparently isn't interested it maintaining their tools.

So this works ? Has anyone tried this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants