Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type annotations for public API + flake8 fixes #627

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guneemwelloeux
Copy link

@guneemwelloeux guneemwelloeux commented Jul 20, 2022

This relates to issue #626

@google-cla
Copy link

google-cla bot commented Jul 20, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lahirumaramba
Copy link
Member

Thank you @guneemwelloeux for your contribution! Would you be able to check the failing CIs? Thanks!

@@ -307,3 +309,5 @@ def _cleanup(self):
if hasattr(service, 'close') and hasattr(service.close, '__call__'):
service.close()
self._services = None

App.update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is. Just pushed an update to my branch. I did run the unit tests before, all passed.

Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing CIs. Thanks!

@mohitCodepy mohitCodepy mentioned this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants