Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type hints #689

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Added type hints #689

wants to merge 1 commit into from

Conversation

mohitCodepy
Copy link

Added type hints for better readability and correct types.

Related to issue #626

@mohitCodepy mohitCodepy marked this pull request as draft March 30, 2023 08:00
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mohitCodepy for your contribution. Is this a duplicate of #627 ?

@mohitCodepy
Copy link
Author

mohitCodepy commented Mar 30, 2023

Thank you @mohitCodepy for your contribution. Is this a duplicate of #627 ?

@lahirumaramba , Actually #627 has some missing type hints, so this PR currently in draft
I'll make changes to the remaining files and then open this PR for review also fixing the CI along.

Thanks

@mohitCodepy
Copy link
Author

@lahirumaramba ,

May I continue to push changes to this PR?
I want to work regularly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants