Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataconnect: LocalDate and LocalDateSerializer added #6434

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Nov 5, 2024

This PR adds the Firebase Data Connect classes LocalDate and LocalDateSerializer, which will replace java.util.Date. Tests will be added in a follow-up PR due to a dependency on the data connect emulator.

These changes are required by v1.6.1 or later of the Firebase Data Connect emulator code generation, which is included with firebase-tools v13.24.2 (https://github.com/firebase/firebase-tools/releases/tag/v13.24.2).

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-dataconnect
### {{data_connect_short}} version 16.0.0-beta03 {: #data-connect_v16-0-0-beta03}

* {{changed}} Requires Data Connect emulator version 1.6.1 or later for code generation.

* {{feature}} QueryRef and MutationRef gain methods copy(), withDataDeserializer(),
  and withVariablesSerializer().
  (GitHub [#6424](//github.com/firebase/firebase-android-sdk/issues/6424){: .external})

* {{feature}} GeneratedConnector gains methods copy(), operations(), queries(),
  and mutations().
  (GitHub [#6424](//github.com/firebase/firebase-android-sdk/issues/6424){: .external})

* {{feature}} GeneratedQuery and GeneratedMutation gain methods copy(),
  withVariablesSerializer(), and withDataDeserializer().
  (GitHub [#6424](//github.com/firebase/firebase-android-sdk/issues/6424){: .external})

* {{feature}} GeneratedConnector, GeneratedQuery, and GeneratedMutation now
  must implement equals() to be a _logical_ comparsion, rather than just
  checking for _referencial_ equality using the `===` operator.
  (GitHub [#6424](//github.com/firebase/firebase-android-sdk/issues/6424){: .external})

* {{feature}} ExperimentalFirebaseDataConnect annotation added, and some
  APIs have been annotated with it, requiring applications that make use of
  these experimental APIs to opt-in using
  `@OptIn(ExperimentalFirebaseDataConnect::class)` to suppress warnings or
  errors related to using these experimental APIs.
  (GitHub [#6424](//github.com/firebase/firebase-android-sdk/issues/6424){: .external}) and
  (GitHub [#6433](//github.com/firebase/firebase-android-sdk/issues/6433){: .external})

* {{changed}} Replaced java.util.Date with
  com.google.firebase.dataconnect.LocalDate.
  (GitHub [#6434](//github.com/firebase/firebase-android-sdk/issues/6434){: .external})

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.1

@dconeybe dconeybe enabled auto-merge (squash) November 5, 2024 22:02
@dconeybe dconeybe merged commit 80019ca into main Nov 5, 2024
36 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/LocalDateApi branch November 5, 2024 22:07
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Test Results

   54 files  ±0     54 suites  ±0   2m 11s ⏱️ +14s
  515 tests ±0    514 ✅ ±0  1 💤 ±0  0 ❌ ±0 
1 030 runs  ±0  1 028 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit ebac48d. ± Comparison against base commit 93640ce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants