-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dataconnect: GrpcMetadataIntegrationTest.kt: Fix race condition waiting for auth/appcheck to be ready #6446
dataconnect: GrpcMetadataIntegrationTest.kt: Fix race condition waiting for auth/appcheck to be ready #6446
Conversation
…ppcheck to be ready
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
1 similar comment
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Vertex AI Mock Responses Check
|
Test Results 54 files - 454 54 suites - 454 2m 10s ⏱️ - 10m 41s Results for commit 82d9331. ± Comparison against base commit 4100ebf. This pull request removes 2420 and adds 2 tests. Note that renamed tests count towards both.
|
This PR fixes a race condition in
GrpcMetadataIntegrationTest.kt
where the query/mutation may be sent before the Auth and/or AppCheck provider was registered, which is done asynchronously. This race condition resulted in flaky tests. We may want to expose this functionality to customers if they run into similar issues.For the record, the test case failures look like this:
Note: This PR introduced a race condition that was fixed a few commits later in #6448