Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataconnect: relax variance of the NullableReference type parameter to covariant (was invariant) #6511

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

dconeybe
Copy link
Contributor

This is an internal-only improvement and has no effects on customers.

Copy link
Contributor

github-actions bot commented Nov 13, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

Copy link
Contributor

Test Results

   58 files  ±0     58 suites  ±0   2m 2s ⏱️ -2s
  535 tests ±0    534 ✅ ±0  1 💤 ±0  0 ❌ ±0 
1 070 runs  ±0  1 068 ✅ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit a161e3d. ± Comparison against base commit c737e21.

@dconeybe dconeybe merged commit d6bfc7b into main Nov 13, 2024
41 checks passed
@dconeybe dconeybe deleted the dconeybe/dataconnect/NullableReferenceTweaks branch November 13, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants