Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace uses of Poperty<File> with FileProperty in plugins #6516

Merged
merged 8 commits into from
Nov 15, 2024
Merged

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Nov 14, 2024

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.2

Copy link
Contributor

github-actions bot commented Nov 14, 2024

buildSrc Test Results

37 tests   37 ✅  1m 6s ⏱️
 8 suites   0 💤
 8 files     0 ❌

Results for commit 709cc41.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-installations_ktx:
error: Removed package com.google.firebase.installations.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-functions_ktx:
error: Removed package com.google.firebase.functions.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-dynamic-links_ktx:
error: Removed package com.google.firebase.dynamiclinks.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-crashlytics_ktx:
error: Removed package com.google.firebase.crashlytics.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-storage_ktx:
error: Removed package com.google.firebase.storage.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-database_ktx:
error: Removed package com.google.firebase.database.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-inappmessaging_ktx:
error: Removed package com.google.firebase.inappmessaging.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-sessions:
error: Removed package com.google.firebase.sessions.api [RemovedPackage]

The public api surface has changed for the subproject firebase-appdistribution-api_ktx:
error: Removed package com.google.firebase.appdistribution.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-dataconnect:
error: Removed package com.google.firebase.dataconnect [RemovedPackage]
error: Removed package com.google.firebase.dataconnect.generated [RemovedPackage]
error: Removed package com.google.firebase.dataconnect.serializers [RemovedPackage]

The public api surface has changed for the subproject firebase-config_ktx:
error: Removed package com.google.firebase.remoteconfig.ktx [RemovedPackage]

The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx:
error: Removed package com.google.firebase.appcheck.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-messaging_ktx:
error: Removed package com.google.firebase.messaging.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-inappmessaging-display_ktx:
error: Removed package com.google.firebase.inappmessaging.display.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx:
error: Removed package com.google.firebase.ml.modeldownloader.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-firestore_ktx:
error: Removed package com.google.firebase.firestore.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-common_ktx:
error: Removed package com.google.firebase.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-perf_ktx:
error: Removed package com.google.firebase.perf.ktx [RemovedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

Copy link
Contributor

github-actions bot commented Nov 14, 2024

Test Results

 1 036 files  +   974   1 036 suites  +974   36m 51s ⏱️ + 34m 30s
 5 873 tests + 5 332   5 851 ✅ + 5 311  22 💤 +21  0 ❌ ±0 
11 831 runs  +10 749  11 787 ✅ +10 707  44 💤 +42  0 ❌ ±0 

Results for commit 709cc41. ± Comparison against base commit 39e7c92.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-installations_ktx:
error: Removed package com.google.firebase.installations.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-functions_ktx:
error: Removed package com.google.firebase.functions.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-dynamic-links_ktx:
error: Removed package com.google.firebase.dynamiclinks.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-crashlytics_ktx:
error: Removed package com.google.firebase.crashlytics.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-storage_ktx:
error: Removed package com.google.firebase.storage.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-database_ktx:
error: Removed package com.google.firebase.database.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-inappmessaging_ktx:
error: Removed package com.google.firebase.inappmessaging.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-sessions:
error: Removed package com.google.firebase.sessions.api [RemovedPackage]

The public api surface has changed for the subproject firebase-appdistribution-api_ktx:
error: Removed package com.google.firebase.appdistribution.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-dataconnect:
error: Removed package com.google.firebase.dataconnect [RemovedPackage]
error: Removed package com.google.firebase.dataconnect.generated [RemovedPackage]
error: Removed package com.google.firebase.dataconnect.serializers [RemovedPackage]

The public api surface has changed for the subproject firebase-config_ktx:
error: Removed package com.google.firebase.remoteconfig.ktx [RemovedPackage]

The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx:
error: Removed package com.google.firebase.appcheck.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-messaging_ktx:
error: Removed package com.google.firebase.messaging.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-inappmessaging-display_ktx:
error: Removed package com.google.firebase.inappmessaging.display.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx:
error: Removed package com.google.firebase.ml.modeldownloader.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-firestore_ktx:
error: Removed package com.google.firebase.firestore.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-common_ktx:
error: Removed package com.google.firebase.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-perf_ktx:
error: Removed package com.google.firebase.perf.ktx [RemovedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

1 similar comment
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-installations_ktx:
error: Removed package com.google.firebase.installations.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-functions_ktx:
error: Removed package com.google.firebase.functions.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-dynamic-links_ktx:
error: Removed package com.google.firebase.dynamiclinks.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-crashlytics_ktx:
error: Removed package com.google.firebase.crashlytics.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-storage_ktx:
error: Removed package com.google.firebase.storage.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-database_ktx:
error: Removed package com.google.firebase.database.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-inappmessaging_ktx:
error: Removed package com.google.firebase.inappmessaging.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-sessions:
error: Removed package com.google.firebase.sessions.api [RemovedPackage]

The public api surface has changed for the subproject firebase-appdistribution-api_ktx:
error: Removed package com.google.firebase.appdistribution.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-dataconnect:
error: Removed package com.google.firebase.dataconnect [RemovedPackage]
error: Removed package com.google.firebase.dataconnect.generated [RemovedPackage]
error: Removed package com.google.firebase.dataconnect.serializers [RemovedPackage]

The public api surface has changed for the subproject firebase-config_ktx:
error: Removed package com.google.firebase.remoteconfig.ktx [RemovedPackage]

The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx:
error: Removed package com.google.firebase.appcheck.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-messaging_ktx:
error: Removed package com.google.firebase.messaging.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-inappmessaging-display_ktx:
error: Removed package com.google.firebase.inappmessaging.display.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx:
error: Removed package com.google.firebase.ml.modeldownloader.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-firestore_ktx:
error: Removed package com.google.firebase.firestore.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-common_ktx:
error: Removed package com.google.firebase.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-perf_ktx:
error: Removed package com.google.firebase.perf.ktx [RemovedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-installations_ktx:
error: Removed package com.google.firebase.installations.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-functions_ktx:
error: Removed package com.google.firebase.functions.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-dynamic-links_ktx:
error: Removed package com.google.firebase.dynamiclinks.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-crashlytics_ktx:
error: Removed package com.google.firebase.crashlytics.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-storage_ktx:
error: Removed package com.google.firebase.storage.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-database_ktx:
error: Removed package com.google.firebase.database.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-inappmessaging_ktx:
error: Removed package com.google.firebase.inappmessaging.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-sessions:
error: Removed package com.google.firebase.sessions.api [RemovedPackage]

The public api surface has changed for the subproject firebase-appdistribution-api_ktx:
error: Removed package com.google.firebase.appdistribution.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-dataconnect:
error: Removed package com.google.firebase.dataconnect [RemovedPackage]
error: Removed package com.google.firebase.dataconnect.generated [RemovedPackage]
error: Removed package com.google.firebase.dataconnect.serializers [RemovedPackage]

The public api surface has changed for the subproject firebase-config_ktx:
error: Removed package com.google.firebase.remoteconfig.ktx [RemovedPackage]

The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx:
error: Removed package com.google.firebase.appcheck.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-messaging_ktx:
error: Removed package com.google.firebase.messaging.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-inappmessaging-display_ktx:
error: Removed package com.google.firebase.inappmessaging.display.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx:
error: Removed package com.google.firebase.ml.modeldownloader.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-firestore_ktx:
error: Removed package com.google.firebase.firestore.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-common_ktx:
error: Removed package com.google.firebase.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-perf_ktx:
error: Removed package com.google.firebase.perf.ktx [RemovedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@rlazo rlazo requested a review from daymxn November 14, 2024 19:26
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-installations_ktx:
error: Removed package com.google.firebase.installations.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-functions_ktx:
error: Removed package com.google.firebase.functions.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-dynamic-links_ktx:
error: Removed package com.google.firebase.dynamiclinks.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-crashlytics_ktx:
error: Removed package com.google.firebase.crashlytics.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-storage_ktx:
error: Removed package com.google.firebase.storage.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-database_ktx:
error: Removed package com.google.firebase.database.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-inappmessaging_ktx:
error: Removed package com.google.firebase.inappmessaging.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-sessions:
error: Removed package com.google.firebase.sessions.api [RemovedPackage]

The public api surface has changed for the subproject firebase-appdistribution-api_ktx:
error: Removed package com.google.firebase.appdistribution.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-dataconnect:
error: Removed package com.google.firebase.dataconnect [RemovedPackage]
error: Removed package com.google.firebase.dataconnect.generated [RemovedPackage]
error: Removed package com.google.firebase.dataconnect.serializers [RemovedPackage]

The public api surface has changed for the subproject firebase-config_ktx:
error: Removed package com.google.firebase.remoteconfig.ktx [RemovedPackage]

The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx:
error: Removed package com.google.firebase.appcheck.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-messaging_ktx:
error: Removed package com.google.firebase.messaging.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-inappmessaging-display_ktx:
error: Removed package com.google.firebase.inappmessaging.display.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx:
error: Removed package com.google.firebase.ml.modeldownloader.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-firestore_ktx:
error: Removed package com.google.firebase.firestore.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-common_ktx:
error: Removed package com.google.firebase.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-perf_ktx:
error: Removed package com.google.firebase.perf.ktx [RemovedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

1 similar comment
@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-installations_ktx:
error: Removed package com.google.firebase.installations.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-functions_ktx:
error: Removed package com.google.firebase.functions.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-dynamic-links_ktx:
error: Removed package com.google.firebase.dynamiclinks.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-crashlytics_ktx:
error: Removed package com.google.firebase.crashlytics.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-storage_ktx:
error: Removed package com.google.firebase.storage.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-database_ktx:
error: Removed package com.google.firebase.database.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-inappmessaging_ktx:
error: Removed package com.google.firebase.inappmessaging.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-sessions:
error: Removed package com.google.firebase.sessions.api [RemovedPackage]

The public api surface has changed for the subproject firebase-appdistribution-api_ktx:
error: Removed package com.google.firebase.appdistribution.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-dataconnect:
error: Removed package com.google.firebase.dataconnect [RemovedPackage]
error: Removed package com.google.firebase.dataconnect.generated [RemovedPackage]
error: Removed package com.google.firebase.dataconnect.serializers [RemovedPackage]

The public api surface has changed for the subproject firebase-config_ktx:
error: Removed package com.google.firebase.remoteconfig.ktx [RemovedPackage]

The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx:
error: Removed package com.google.firebase.appcheck.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-messaging_ktx:
error: Removed package com.google.firebase.messaging.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-inappmessaging-display_ktx:
error: Removed package com.google.firebase.inappmessaging.display.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx:
error: Removed package com.google.firebase.ml.modeldownloader.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-firestore_ktx:
error: Removed package com.google.firebase.firestore.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-common_ktx:
error: Removed package com.google.firebase.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-perf_ktx:
error: Removed package com.google.firebase.perf.ktx [RemovedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-installations_ktx:
error: Removed package com.google.firebase.installations.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-functions_ktx:
error: Removed package com.google.firebase.functions.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-dynamic-links_ktx:
error: Removed package com.google.firebase.dynamiclinks.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-crashlytics_ktx:
error: Removed package com.google.firebase.crashlytics.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-storage_ktx:
error: Removed package com.google.firebase.storage.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-database_ktx:
error: Removed package com.google.firebase.database.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-inappmessaging_ktx:
error: Removed package com.google.firebase.inappmessaging.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-sessions:
error: Removed package com.google.firebase.sessions.api [RemovedPackage]

The public api surface has changed for the subproject firebase-appdistribution-api_ktx:
error: Removed package com.google.firebase.appdistribution.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-dataconnect:
error: Removed package com.google.firebase.dataconnect [RemovedPackage]
error: Removed package com.google.firebase.dataconnect.generated [RemovedPackage]
error: Removed package com.google.firebase.dataconnect.serializers [RemovedPackage]

The public api surface has changed for the subproject firebase-config_ktx:
error: Removed package com.google.firebase.remoteconfig.ktx [RemovedPackage]

The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx:
error: Removed package com.google.firebase.appcheck.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-messaging_ktx:
error: Removed package com.google.firebase.messaging.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-inappmessaging-display_ktx:
error: Removed package com.google.firebase.inappmessaging.display.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx:
error: Removed package com.google.firebase.ml.modeldownloader.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-firestore_ktx:
error: Removed package com.google.firebase.firestore.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-common_ktx:
error: Removed package com.google.firebase.ktx [RemovedPackage]

The public api surface has changed for the subproject firebase-perf_ktx:
error: Removed package com.google.firebase.perf.ktx [RemovedPackage]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is likely wrong with the api generation, see the test failures for context.

@rlazo rlazo requested a review from daymxn November 15, 2024 19:42
@rlazo
Copy link
Collaborator Author

rlazo commented Nov 15, 2024

Something is likely wrong with the api generation, see the test failures for context.

Addressed

@rlazo rlazo merged commit f7acdac into main Nov 15, 2024
260 of 262 checks passed
@rlazo rlazo deleted the rl.file.prop branch November 15, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants