-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace uses of Poperty<File> with FileProperty in plugins #6516
Conversation
This is the recommended approach by Gradle https://docs.gradle.org/current/userguide/properties_providers.html#managed_properties
Release note changesNo release note changes were detected. If you made changes that should be |
Vertex AI Mock Responses Check
|
buildSrc Test Results37 tests 37 ✅ 1m 6s ⏱️ Results for commit 709cc41. ♻️ This comment has been updated with latest results. |
The public api surface has changed for the subproject firebase-installations_ktx: The public api surface has changed for the subproject firebase-functions_ktx: The public api surface has changed for the subproject firebase-dynamic-links_ktx: The public api surface has changed for the subproject firebase-crashlytics_ktx: The public api surface has changed for the subproject firebase-storage_ktx: The public api surface has changed for the subproject firebase-database_ktx: The public api surface has changed for the subproject firebase-inappmessaging_ktx: The public api surface has changed for the subproject firebase-sessions: The public api surface has changed for the subproject firebase-appdistribution-api_ktx: The public api surface has changed for the subproject firebase-dataconnect: The public api surface has changed for the subproject firebase-config_ktx: The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx: The public api surface has changed for the subproject firebase-messaging_ktx: The public api surface has changed for the subproject firebase-inappmessaging-display_ktx: The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx: The public api surface has changed for the subproject firebase-firestore_ktx: The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-perf_ktx: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject firebase-installations_ktx: The public api surface has changed for the subproject firebase-functions_ktx: The public api surface has changed for the subproject firebase-dynamic-links_ktx: The public api surface has changed for the subproject firebase-crashlytics_ktx: The public api surface has changed for the subproject firebase-storage_ktx: The public api surface has changed for the subproject firebase-database_ktx: The public api surface has changed for the subproject firebase-inappmessaging_ktx: The public api surface has changed for the subproject firebase-sessions: The public api surface has changed for the subproject firebase-appdistribution-api_ktx: The public api surface has changed for the subproject firebase-dataconnect: The public api surface has changed for the subproject firebase-config_ktx: The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx: The public api surface has changed for the subproject firebase-messaging_ktx: The public api surface has changed for the subproject firebase-inappmessaging-display_ktx: The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx: The public api surface has changed for the subproject firebase-firestore_ktx: The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-perf_ktx: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
1 similar comment
The public api surface has changed for the subproject firebase-installations_ktx: The public api surface has changed for the subproject firebase-functions_ktx: The public api surface has changed for the subproject firebase-dynamic-links_ktx: The public api surface has changed for the subproject firebase-crashlytics_ktx: The public api surface has changed for the subproject firebase-storage_ktx: The public api surface has changed for the subproject firebase-database_ktx: The public api surface has changed for the subproject firebase-inappmessaging_ktx: The public api surface has changed for the subproject firebase-sessions: The public api surface has changed for the subproject firebase-appdistribution-api_ktx: The public api surface has changed for the subproject firebase-dataconnect: The public api surface has changed for the subproject firebase-config_ktx: The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx: The public api surface has changed for the subproject firebase-messaging_ktx: The public api surface has changed for the subproject firebase-inappmessaging-display_ktx: The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx: The public api surface has changed for the subproject firebase-firestore_ktx: The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-perf_ktx: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
buildSrc/src/main/java/com/google/firebase/gradle/plugins/DackkaPlugin.kt
Outdated
Show resolved
Hide resolved
The public api surface has changed for the subproject firebase-installations_ktx: The public api surface has changed for the subproject firebase-functions_ktx: The public api surface has changed for the subproject firebase-dynamic-links_ktx: The public api surface has changed for the subproject firebase-crashlytics_ktx: The public api surface has changed for the subproject firebase-storage_ktx: The public api surface has changed for the subproject firebase-database_ktx: The public api surface has changed for the subproject firebase-inappmessaging_ktx: The public api surface has changed for the subproject firebase-sessions: The public api surface has changed for the subproject firebase-appdistribution-api_ktx: The public api surface has changed for the subproject firebase-dataconnect: The public api surface has changed for the subproject firebase-config_ktx: The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx: The public api surface has changed for the subproject firebase-messaging_ktx: The public api surface has changed for the subproject firebase-inappmessaging-display_ktx: The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx: The public api surface has changed for the subproject firebase-firestore_ktx: The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-perf_ktx: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject firebase-installations_ktx: The public api surface has changed for the subproject firebase-functions_ktx: The public api surface has changed for the subproject firebase-dynamic-links_ktx: The public api surface has changed for the subproject firebase-crashlytics_ktx: The public api surface has changed for the subproject firebase-storage_ktx: The public api surface has changed for the subproject firebase-database_ktx: The public api surface has changed for the subproject firebase-inappmessaging_ktx: The public api surface has changed for the subproject firebase-sessions: The public api surface has changed for the subproject firebase-appdistribution-api_ktx: The public api surface has changed for the subproject firebase-dataconnect: The public api surface has changed for the subproject firebase-config_ktx: The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx: The public api surface has changed for the subproject firebase-messaging_ktx: The public api surface has changed for the subproject firebase-inappmessaging-display_ktx: The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx: The public api surface has changed for the subproject firebase-firestore_ktx: The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-perf_ktx: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
1 similar comment
The public api surface has changed for the subproject firebase-installations_ktx: The public api surface has changed for the subproject firebase-functions_ktx: The public api surface has changed for the subproject firebase-dynamic-links_ktx: The public api surface has changed for the subproject firebase-crashlytics_ktx: The public api surface has changed for the subproject firebase-storage_ktx: The public api surface has changed for the subproject firebase-database_ktx: The public api surface has changed for the subproject firebase-inappmessaging_ktx: The public api surface has changed for the subproject firebase-sessions: The public api surface has changed for the subproject firebase-appdistribution-api_ktx: The public api surface has changed for the subproject firebase-dataconnect: The public api surface has changed for the subproject firebase-config_ktx: The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx: The public api surface has changed for the subproject firebase-messaging_ktx: The public api surface has changed for the subproject firebase-inappmessaging-display_ktx: The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx: The public api surface has changed for the subproject firebase-firestore_ktx: The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-perf_ktx: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
The public api surface has changed for the subproject firebase-installations_ktx: The public api surface has changed for the subproject firebase-functions_ktx: The public api surface has changed for the subproject firebase-dynamic-links_ktx: The public api surface has changed for the subproject firebase-crashlytics_ktx: The public api surface has changed for the subproject firebase-storage_ktx: The public api surface has changed for the subproject firebase-database_ktx: The public api surface has changed for the subproject firebase-inappmessaging_ktx: The public api surface has changed for the subproject firebase-sessions: The public api surface has changed for the subproject firebase-appdistribution-api_ktx: The public api surface has changed for the subproject firebase-dataconnect: The public api surface has changed for the subproject firebase-config_ktx: The public api surface has changed for the subproject appcheck_firebase-appcheck_ktx: The public api surface has changed for the subproject firebase-messaging_ktx: The public api surface has changed for the subproject firebase-inappmessaging-display_ktx: The public api surface has changed for the subproject firebase-ml-modeldownloader_ktx: The public api surface has changed for the subproject firebase-firestore_ktx: The public api surface has changed for the subproject firebase-common_ktx: The public api surface has changed for the subproject firebase-perf_ktx: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is likely wrong with the api generation, see the test failures for context.
Addressed |
This is the recommended approach by Gradle
https://docs.gradle.org/current/userguide/properties_providers.html#managed_properties