FIX: Add wrapTraceContext to onChangedOperation to enable traceId on onDocumentUpdated #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…estore triggers to get the trace information
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hey @JonatanSalas. Can you fix the conflicts? |
|
@exaby73 sure! |
|
Hey @JonatanSalas. There still seems to be conflicts on this PR |
|
This was fixed in #1531! Thank you for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using firebase-functions v2
traceIdis missing for Firestore triggers likeonDocumentUpdated.After a deep dive into the repository's code I've found that there's a difference.
onDocumentCreatedrelies in the methodonOperationwhich wraps the event handler with the functionwrapTraceContextthat injects thetraceinformation.On the other side,
onDocumentUpdatedrelies in the methodonChangedOperationwhich executes the event handler without using thewrapTraceContextfunction. I don't know if this is intentional, but this is a problem of those who are heavy users of firebase functions under the v2 because in previous version thetraceIdwas available.I've adapted the code to make
onChangedOperationuse thewrapTraceContextfunction. With that line I think we can solve the issue of missingtraceIdinonDocumentUpdated.