Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Dependencies when running Firebase Init Functions #1572

Open
JamesVanWaza opened this issue Jun 4, 2024 · 7 comments
Open

Incorrect Dependencies when running Firebase Init Functions #1572

JamesVanWaza opened this issue Jun 4, 2024 · 7 comments

Comments

@JamesVanWaza
Copy link

JamesVanWaza commented Jun 4, 2024

Related issues

[REQUIRED] Version info

NODE: 20.14.0
NPM: 10.7.0

firebase-functions:

firebase-tools:

firebase-admin:

[REQUIRED] Test case

[REQUIRED] Steps to reproduce

Run npm outdated to update the packages

[REQUIRED] Expected behavior

[REQUIRED] Actual behavior

Screenshot 2024-06-03 at 8 45 56 PM

Were you able to successfully deploy your functions?

When I upgrade eslint to 9.4.0 I can no longer run firebase deploy since the config file has changed.
Also firebase-admin should be updated to 12.1.1
Firebase-functions should be updated to 5.0.1

@google-oss-bot
Copy link
Collaborator

I found a few problems with this issue:

  • I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
  • This issue does not have all the information required by the template. Looks like you forgot to fill out some sections. Please update the issue with more information.

@exaby73
Copy link
Contributor

exaby73 commented Jun 17, 2024

Hello @JamesVanWaza. Can you provide information about the Firebase CLI version via running firebase --version. Please unsure you're on the latest version via running npm install -g firebase-tools

@exaby73 exaby73 added Needs: Author Feedback Issues awaiting author feedback and removed needs-triage labels Jun 17, 2024
@JamesVanWaza
Copy link
Author

@exaby73
firebase --version: 13.7.1

Screenshot 2024-06-17 at 7 42 50 PM

@google-oss-bot google-oss-bot added Needs: Attention and removed Needs: Author Feedback Issues awaiting author feedback labels Jun 17, 2024
@exaby73
Copy link
Contributor

exaby73 commented Jul 15, 2024

There seems to be an update to the CLI available. Could you update and try again?

@exaby73 exaby73 added Needs: Author Feedback Issues awaiting author feedback and removed Needs: Attention labels Jul 15, 2024
@JamesVanWaza
Copy link
Author

JamesVanWaza commented Jul 15, 2024

@exaby73 I have updated my CLI but when you run firebase deploy this error keeps happening

Screenshot 2024-07-15 at 7 49 31 PM

The .eslintrc.js file needs to be configured to eslint.config.js to match the new Migration

@google-oss-bot google-oss-bot added Needs: Attention and removed Needs: Author Feedback Issues awaiting author feedback labels Jul 15, 2024
@exaby73
Copy link
Contributor

exaby73 commented Jul 23, 2024

You'll have to migrate this yourself. Currently, firebase init functions installed eslint version ^8.9.0. I just checked

@exaby73 exaby73 added Needs: Author Feedback Issues awaiting author feedback and removed Needs: Attention labels Jul 23, 2024
@JamesVanWaza
Copy link
Author

@exaby73 sounds good. Will wait for the update then instead of reverting to 8.9.0

@google-oss-bot google-oss-bot added Needs: Attention and removed Needs: Author Feedback Issues awaiting author feedback labels Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants