Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork generative-ai-swift tests for Vertex AI #12584

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Fork generative-ai-swift tests for Vertex AI #12584

merged 2 commits into from
Mar 19, 2024

Conversation

andrewheard
Copy link
Contributor

Copied https://github.com/google/generative-ai-swift/tree/48a0c2f11935a17132492583d4aad51c5a407bcb/Tests/GoogleAITests. These files are unmodified and not yet used in the Swift package.

#no-changelog

@andrewheard andrewheard marked this pull request as ready for review March 19, 2024 14:58
paulb777
paulb777 approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you update Package.swift to build these and vertexai.yml to CI them in this or a subsequent PR

@paulb777
Copy link
Member

nvm, I remember the plan now.

@andrewheard andrewheard merged commit 2b53776 into vertex-ai Mar 19, 2024
36 checks passed
@andrewheard andrewheard deleted the ah/vertex-ai-tests branch March 19, 2024 15:44
paulb777 pushed a commit that referenced this pull request Apr 2, 2024
@andrewheard @paulb777
Fork generative-ai-swift tests for Vertex AI (#12584)
cb2f143
@firebase firebase locked and limited conversation to collaborators Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewheard @paulb777