Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable AppCheck for DataConnect #13648

Closed
wants to merge 1 commit into from
Closed

Enable AppCheck for DataConnect #13648

wants to merge 1 commit into from

Conversation

cherylEnkidu
Copy link
Contributor

#no-changelog

paulb777
paulb777 reviewed Sep 16, 2024
View reviewed changes
FirebaseDataConnect/Sources/Internal/GrpcClient.swift
}
} catch {
do {
if let token = try await appCheck?.token(forcingRefresh: false) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should appCheck be accessed via interop like the other products?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. I will merge this public version into the new repo for now and explore interop way.

@paulb777 paulb777 closed this Oct 16, 2024
@firebase firebase locked and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cherylEnkidu @paulb777