Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signInWithPopup() lacks API to pass size hints #8612

Open
ensonic opened this issue Oct 28, 2024 · 1 comment
Open

signInWithPopup() lacks API to pass size hints #8612

ensonic opened this issue Oct 28, 2024 · 1 comment

Comments

@ensonic
Copy link

ensonic commented Oct 28, 2024

Operating System

Any

Environment (if applicable)

Google Chrome 130.0.6723.58 (Official Build) (64-bit)

Firebase SDK Version

10.12.0

Firebase SDK Product(s)

Auth

Project Tooling

Angular app.

Detailed Problem Description

We use signInWithPopup() also with customOIDC providers. For some providers the popup cuts off the login button (at the button of the popup).
The window size is hardcoded to 500 x 600 in

const DEFAULT_WIDTH = 500;
const DEFAULT_HEIGHT = 600;

The parameters are not exposed publicly as it seems (please correct me if I am wrong).

In the past I could see the default for known providers in idp.js (see e.g. https://github.com/firebase/firebase-js-sdk/pull/2966/files).

The file was removed in a huge PR #5345, that is hard to read and reason to see where things went.

Steps and code to reproduce issue

See problem desc

@ensonic ensonic added new A new issue that hasn't be categoirzed as question, bug or feature request question labels Oct 28, 2024
@google-oss-bot
Copy link
Contributor

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@jbalidiong jbalidiong added api: auth needs-attention and removed needs-triage new A new issue that hasn't be categoirzed as question, bug or feature request labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants