-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emulator UI doesn't respect the host configuration. #912
Comments
I missed it, but it is probably the same issue as #874 |
@yuchenshi Is this part of firebase-tools 11.22.0? Not sure how to get which version of firebase-tools-ui it uses. |
@creack We've still haven't got a chance to cut an Emulator UI release yet, but it will be included in the next one. I'll update this thread when the fix is released. |
Fixed in v11.23.1 |
UPDATE: I'm still having this issue. I was on the latest version of Firebase Tools 11.24, but I also tried on 11.23.1. Is there something else I need to update to get this working? |
@yuchenshi, I just tried on 11.24. Works like charm. Thanks! |
@yuchenshi The UI is still trying to connect to 0.0.0.0 when I follow @creack steps here to build a docker container. My config is as follows
I am also using in local mode I can also confirm that the request for 0.0.0.0 is on port 5002 |
@yuchenshi can you advise if I should open another issue or not related to this? When visitng the logs tab, the site still tries to access 127.0.0.7 as per my screenshot above |
@muzzah I no longer work on the team, but please make sure For your other issue, |
Describe the bug
Setting the
host
field infirebase.json
isn't respected anymore to access emulators. The UI always tries to access them on 127.0.0.1, regardless of the config or from where it is accessed.In version 9, it was working as expected and the UI was using
window.location
or something like that to call the emulators on the same domain as it was being accessed.Running in Docker and/or on a different machine results in the UI being broken.
To Reproduce
Run the emulator with
Expected behavior
The UI should be able to access emulators outside localhost.
Screenshots/Logs
V11 - Broken
CLI Logs:
Resulting Hub config for V11
Browser network Tab V11 - Broken
V9 - Working
The same configuration was working fine in v9.23.3.
CLI logs:
Resulting Hub config for v9
Browser network tab V9 - Working
The UI should load and access the emulators on the domain it is serving.
Additional context
Running on Docker linux/amd64.
To reproduce the issue:
Common Dockerfile:
Working as expected:
docker build -t fbui:v9 --build-arg=FIREBASE_VERSION=9.23.3 --build-arg=HOST=0.0.0.0 . docker run --rm -it -p 9001-9002:9001-9002 fbui:v9
Not working:
docker build -t fbui:v11 --build-arg=FIREBASE_VERSION=11.21.0 --build-arg=HOST=0.0.0.0 . docker run --rm -it -p 9001-9002:9001-9002 fbui:v11
NOTE: I also tried to run the UI under a valid https domain, just in case, but same result.
The text was updated successfully, but these errors were encountered: