From 51fca742a96317de4abfb3bfcf6e5ba9386513f3 Mon Sep 17 00:00:00 2001
From: a-maurice <amaurice@google.com>
Date: Wed, 13 Nov 2024 16:42:07 -0800
Subject: [PATCH] Disable new SWIG string helper functions (#1145)

---
 cmake/firebase_swig.cmake | 4 ++++
 docs/readme.md            | 5 +++++
 2 files changed, 9 insertions(+)

diff --git a/cmake/firebase_swig.cmake b/cmake/firebase_swig.cmake
index db69bc9e..557d9a87 100644
--- a/cmake/firebase_swig.cmake
+++ b/cmake/firebase_swig.cmake
@@ -154,6 +154,10 @@ macro(firebase_swig_add_library name)
     # https://github.com/swig/swig/issues/672#issuecomment-400577864
     final=
     USE_EXPORT_FIX
+    # SWIG 4.3 added a C# class, SWIGStringWithLengthHelper, but is missing
+    # the corresponding C++ symbols, which can cause issues. We don't
+    # rely on this class anyway, so just disable it.
+    SWIG_CSHARP_NO_STRING_WITH_LENGTH_HELPER
   )
 
   set_property(TARGET ${name} PROPERTY SWIG_GENERATED_COMPILE_DEFINITIONS
diff --git a/docs/readme.md b/docs/readme.md
index 49cc6898..33da9fc3 100644
--- a/docs/readme.md
+++ b/docs/readme.md
@@ -71,6 +71,11 @@ Support
 
 Release Notes
 -------------
+### Upcoming
+- Changes
+    - General: Remove unresolved SWIG string symbols.
+      ([#1139](https://github.com/firebase/firebase-unity-sdk/issues/1139)).
+
 ### 12.4.0
 - Changes
     - General: Update to Firebase C++ SDK version 12.4.0.