Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Unity Package Manager git support (again) #1057

Open
calumma-robert opened this issue Jul 3, 2024 · 5 comments
Open

[FR]: Unity Package Manager git support (again) #1057

calumma-robert opened this issue Jul 3, 2024 · 5 comments

Comments

@calumma-robert
Copy link

Description

A lot of Google Unity Packages are already (and again) available as a Unity Package Manger git package, like the Google Play Plugins, Google Mobile Ads, etc.

It would just make the integration smoother and also reduces overall footprints on the internet (as i.e. the packages don't need to be checked in) and only downloaded and cached if needed by Unity.

API Proposal

No response

Firebase Product(s)

All

Targeted Platform(s)

Apple Platforms, Android, Desktop

@argzdev argzdev removed the new New issue. label Jul 3, 2024
@argzdev
Copy link

argzdev commented Jul 4, 2024

Hi @calumma-robert, thanks for filing this feature request. However, It seems unclear to me how this would relate to Firebase. Could you share a bit more details? If however, this is not intended for Firebase, please reach out to proper communication channels. In this case, features for Unity would be better reported to the Unity forums.

@argzdev argzdev added the needs-info Need information for the developer label Jul 4, 2024
@calumma-robert
Copy link
Author

Hey @argzdev, sure let me explain!

Currently to install any of the firebase packages to Unity it must be installed directly via the firebase package's .unitypackage file, or by importing it as a local dependency within Unity's Package Manager (UPM) by referencing the downloaded .tgz file of the needed firebase package.

However, most of Google's packages, has already moved to a git-style package, i.e. 'com.google.external-dependency-manager' (which is a dependency of all firebase packages also).

The EDM can simply be installed by adding directly it's git url (+path to the package.json) inside the UPM like this:
https://github.com/googlesamples/unity-jar-resolver.git?path=upm

Integrating it like that, also makes the update process for end-users easier, as you can just press Update within Unity and it will check git for any updates. Additionally, manually downloading the .unitypackage/.tgz is no longer required and the unity project itself is also way cleaner (as it is not saved inside Assets/, and just cached inside Library/...)

With that, each package.json of any firebase package can also easily reference another firebase package as a dependecv, removing the need to bundle all dependencies together (as you have it currently with the .unitypackage approach)

@argzdev
Copy link

argzdev commented Jul 4, 2024

Thank you for the well detailed explanation, @calumma-robert. This does sound like a feature we should be doing. That said, while I'm unable to provide a timeline when we'll be able to add this to the roadmap, I'll bring this up to our engineering team for discussion.

@argzdev argzdev removed the needs-info Need information for the developer label Jul 4, 2024
@calumma-robert
Copy link
Author

Hey @argzdev , out of curiosity: Do you have any ETA for this feature? 🤔

Cheers!

@plotlessplot
Copy link

+1 for this.

Installing the .unitypackage directly into /Assets is cumbersome and contributes to increased LFS costs.

Installing the .tgz as Local packages managed via UPM is a mess for version control, because every contributor needs to have the correct version of the file in the same relative path, which is a pain to manage.

Apart from installing them via a Git URL, EDM4U, Google Mobile Ads and others are also already officially available on OpenUPM, so that could be another viable option for the Firebase modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants