Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React strict mode compatibility #184

Closed
jwhiting opened this issue Nov 2, 2022 · 1 comment
Closed

React strict mode compatibility #184

jwhiting opened this issue Nov 2, 2022 · 1 comment

Comments

@jwhiting
Copy link

jwhiting commented Nov 2, 2022

As surfaced in #59, the FirebaseAuth and StyledFirebaseAuth components are not React strict-mode compatible. In particular both of these components fail to render and throw Error: AuthUI instance is deleted!

Unfortunately, React does not currently offer a way for any part of a strict-mode component tree to opt-out of strict mode (per facebook/react#16362), so the only solution for people using this library appears to be turning strict mode off entirely, or going to great lengths to try to wrap the parts of the tree that do not include this component in strict-mode wrappers, which is extremely error-prone.

@jwhiting
Copy link
Author

jwhiting commented Nov 2, 2022

Actually given that #173 may fix this, and has been awaiting merge for a very long time with no activity, I assume this project is dead, and am closing this issue

@jwhiting jwhiting closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant