Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tooling] the flow runner loses previous input when runtime reconnects #1324

Open
pavelgj opened this issue Nov 18, 2024 · 4 comments
Open
Labels
bug Something isn't working devui tooling
Milestone

Comments

@pavelgj
Copy link
Collaborator

pavelgj commented Nov 18, 2024

No description provided.

@pavelgj pavelgj added bug Something isn't working tooling labels Nov 18, 2024
@pavelgj pavelgj changed the title [Tooling] the flow runner looses previous input when runtime reconnects [Tooling] the flow runner loses previous input when runtime reconnects Nov 18, 2024
@tonybaroneee
Copy link
Collaborator

This is because we hard-refresh the page currently on actions reload. We're looking into a solution to not have to do that, but I bet monaco might still re-render once the actions array is hot-swapped back in, so input would still be lost anyways.

I think the broader solution here is leveraging localStorage to remember flow input + auth JSON (Denis in discord wanted something similar for flow auth to not have to keep re-inputting it on refresh).

@MichaelDoyle
Copy link
Member

Should this be combined with #1310?

@MichaelDoyle
Copy link
Member

@MichaelDoyle MichaelDoyle added this to the js-1.0.0 milestone Nov 20, 2024
@tonybaroneee
Copy link
Collaborator

We decided to just prevent auto-refresh when viewing a runner page, and instead adjust the runtime banner to show that it has been reconnected and offer a button to refresh the page. Show this state until the page is refreshed, or the runtime is disconnected again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working devui tooling
Projects
Status: No status
Development

No branches or pull requests

3 participants