Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messaging example does not compile #1689

Open
dprevost-LMI opened this issue Oct 26, 2024 · 0 comments
Open

Messaging example does not compile #1689

dprevost-LMI opened this issue Oct 26, 2024 · 0 comments

Comments

@dprevost-LMI
Copy link

dprevost-LMI commented Oct 26, 2024

Step 1: Describe your environment

  • Android device: does not matter
  • Android OS version: does not matter
  • Google Play Services version: does not matter
  • Firebase/Play Services SDK version: does not matter

Step 2: Describe the problem:

I had to changes the minSDK of internal/chooserx/build.gradle.kts and internal/lintchecks/build.gradle.kts to have the messaging example compile

Steps to reproduce:

  1. Pull the project
  2. Open /quickstart-android/messaging in Ladybug
  3. Change JDK for temurin 17
  4. Try to compile
  5. Receives error about material lib not in minSDK 19
  6. Change the minSDK as the patch shows below
  7. Rebuilt and it compiles

Observed Results:

Unable to compile

Expected Results:

Able to compile

Relevant Code:

diff --git a/internal/chooserx/build.gradle.kts b/internal/chooserx/build.gradle.kts
index d2d9ac0..0af4887 100755
--- a/internal/chooserx/build.gradle.kts
+++ b/internal/chooserx/build.gradle.kts
@@ -7,7 +7,7 @@ android {
     compileSdk = 35
 
     defaultConfig {
-        minSdk = 16
+        minSdk = 19
         targetSdk = 35
 
         testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
diff --git a/internal/lintchecks/build.gradle.kts b/internal/lintchecks/build.gradle.kts
index 0fc26b9..19b2aa5 100755
--- a/internal/lintchecks/build.gradle.kts
+++ b/internal/lintchecks/build.gradle.kts
@@ -6,7 +6,7 @@ android {
     compileSdk = 35
 
     defaultConfig {
-        minSdk = 16
+        minSdk = 19
         targetSdk = 35
     }
 }
@firebase firebase deleted a comment from ayatk78 Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant