Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support importing simpleperf trace files from Android Studio #5203

Open
nisargjhaveri opened this issue Nov 12, 2024 · 4 comments · May be fixed by #5212
Open

Support importing simpleperf trace files from Android Studio #5203

nisargjhaveri opened this issue Nov 12, 2024 · 4 comments · May be fixed by #5212
Labels
profile data Issues related to the profile format, data structure, or profile upgraders

Comments

@nisargjhaveri
Copy link
Contributor

nisargjhaveri commented Nov 12, 2024

Is it possible to add support for simpleperf trace files generated using Android Studio or simpleperf report-sample commands.

Here is the file format details: https://cs.android.com/android/platform/superproject/main/+/main:system/extras/simpleperf/cmd_report_sample.proto

I can help create a PR if it makes sense to add this support here.

┆Issue is synchronized with this Jira Task

@julienw
Copy link
Contributor

julienw commented Nov 14, 2024

Sure, why not!

@julienw julienw added the profile data Issues related to the profile format, data structure, or profile upgraders label Nov 14, 2024
@canova
Copy link
Member

canova commented Nov 14, 2024

I thought we had support for the simpleperf already. I found a documentation here: https://profiler.firefox.com/docs/#/./guide-android-profiling?id=perf-profiling-on-android

Have you tried these steps here?

@julienw
Copy link
Contributor

julienw commented Nov 14, 2024

I believe it's not the same type of simpleperf output here. The trace format seems to be binary. I don't know how easy it will be to import it! but it's worth trying if you want :-)

@nisargjhaveri
Copy link
Contributor Author

I've made an attempt in #5212. Feel free to suggest any changes as required. :)

@canova, yes those steps works when using simpleperf directly to record profiles and we have the raw perf.data file to work with. But simpleperf also provides another utility to convert perf.data to this particular format via simpleperf report-sample, while taking care of symbolication etc. One benefit of doing this is reduced external dependency on python as ./gecko_profile_generator.py would require that.

Also, when generating profiles from Android Studio, it directly exports profiles into this format and gecko_profile_generator.py does not help in that case anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
profile data Issues related to the profile format, data structure, or profile upgraders
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants