Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Tree filter input clear button isn't accessible #5236

Open
2 tasks
nchevobbe opened this issue Dec 2, 2024 · 2 comments
Open
2 tasks

Call Tree filter input clear button isn't accessible #5236

nchevobbe opened this issue Dec 2, 2024 · 2 comments
Labels
accessibility Related to making the profiler UI accessible

Comments

@nchevobbe
Copy link
Member

nchevobbe commented Dec 2, 2024

  • it doesn't have a label
  • it can't be focused with the keyboard

┆Issue is synchronized with this Jira Task

@julienw julienw added the accessibility Related to making the profiler UI accessible label Dec 2, 2024
@julienw
Copy link
Contributor

julienw commented Dec 2, 2024

Can you put a screenshot of the filter you're mentioning? The call tree filter I see can be focused by keyboard, at least for me on Linux.
It's also enclosed in a label element but the tree is a bit weird indeed, I'm not sure it's properly applied.

@nchevobbe nchevobbe changed the title Call Tree filter input isn't accessible Call Tree filter input clear button isn't accessible Dec 2, 2024
@nchevobbe
Copy link
Member Author

Can you put a screenshot of the filter you're mentioning? The call tree filter I see can be focused by keyboard, at least for me on Linux. It's also enclosed in a label element but the tree is a bit weird indeed, I'm not sure it's properly applied.

Erf, sorry, I forgot some words in the issue title. This is about the filter input clear button
image

You could argue that when you focus the input text is selected so you can hit Delete to do the same thing, but I feel like having a visible button not being accessible with the keyboard isn't great.
FWIW we have the same kind of clear button in the DevTools toolbox and the a11y team did file bug about those buttons not being accessible with the keyboard only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Related to making the profiler UI accessible
Projects
None yet
Development

No branches or pull requests

2 participants