Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Windows system? #29

Closed
holazt opened this issue Dec 12, 2017 · 49 comments
Closed

support Windows system? #29

holazt opened this issue Dec 12, 2017 · 49 comments
Labels
Enhancement Feature requests and code enhancements

Comments

@holazt
Copy link
Member

holazt commented Dec 12, 2017

I change some code and use Mingw32 to build on windows10, It runs well, but there are still some problems, such as color widgets. I upload the compiled application here.

flameshot

@lupoDharkael
Copy link
Collaborator

Flameshot uses functionality specific of Unix-like systems (like DBus). I tried to design it in a way to make it not very hard to port to other systems. I'd like to support more systems as it would help to expand the usage of the program. I have a lot of content to implement from my TODO list and porting requires some time (I'm having exams soon).
I'll keep this open as a reminder.

@lupoDharkael lupoDharkael added the Enhancement Feature requests and code enhancements label Dec 12, 2017
@lupoDharkael
Copy link
Collaborator

As a side note. If you share a binary of a modified version for Windows, please, provide the source code with the modifications as Flameshot is GPL. You may not have bad intentions but that binary could contain anything.

@lupoDharkael
Copy link
Collaborator

fc9c576 should have fixed the errors of the compilation. I think I'll start adapting Flameshot for Windows sooner than I expected.

@holazt
Copy link
Member Author

holazt commented Dec 26, 2017

Sounds great.
Have you solved dbus on Windows system? Maybe, for adapting to different platform features, conditional compilation can use.

@lupoDharkael
Copy link
Collaborator

I'm disabling dbus related code for Windows just to make it work. I'll investigate alternatives for IPC and it will have an alternative implementation in the future.

I have to implement support for global key press detection, a shortcut management menu, an autostart in boot option and other stuff too.

@holazt
Copy link
Member Author

holazt commented Dec 27, 2017

@lupoDharkael Hi, I tell you a good news. There is an open sourced library QHotKey for global shortcuts/hotkeys, which can be used directly in projects. It works on Windows, Mac and X11, currently does not support Wayland and check the details here. I hope this will be helpful to you.

peek 2017-12-27 22-46

@lupoDharkael
Copy link
Collaborator

thanks! It is useful

@b4ssrp
Copy link

b4ssrp commented Dec 31, 2017

May be offtop

There is @greenshot for windows and it has builtin image editor, but it may be slow.

@smaragdus
Copy link

@lupoDharkael
Any approximate deadline for the Windows version?

@davtur19
Copy link

davtur19 commented Apr 9, 2018

Some news?
I'd like to be able to use it on Windows as well, as it's the best tool for screenshots I've ever used

@holazt
Copy link
Member Author

holazt commented Apr 9, 2018

@davtur19 At present, you can use CI daily build version. https://ci.appveyor.com/project/lupoDharkael/flameshot
image

@lupoDharkael
Copy link
Collaborator

lupoDharkael commented Apr 16, 2018

#188 should be fixed before the release for Windows as that release could increase a lot the usage of the program.

@smaragdus
Copy link

I would not call Flameshot version 0.5.1-37-g205cd7c portable since it saves the configuration file (flameshot.ini) not in program folder but in AppData:

C:\Users\UserName\AppData\Roaming\Dharkael\flameshot.ini

I would appreciate a command-line parameter which forces Flameshot to save flameshot.ini in program folder, for example:

flameshot.exe -portable

Time (%H:%M:%S) and Time (%H:%M) are not valid for Windows.

@lupoDharkael
Copy link
Collaborator

Flameshot isn't portable, nor ready for a windows release, it still requires some work.

@smaragdus
Copy link

smaragdus commented Apr 16, 2018

@lupoDharkael
It seems I was mislead by the name of the archive (flameshot_win_x86_portable_0.5.0.zip).
Anyway, please consider a command-line argument which will make Flameshot portable on Windows-
configuration file saved in program folder.
Take your time, I am patient, many Linux programs took years to be ported to Windows.

@ghost
Copy link

ghost commented Jun 27, 2018

I downloaded the zip file and tried to run it, but all i got was an error saying "The code execution cannot proceed because Qt5DBusd.dll was not found. Reinstalling the program may fix this problem."
Thing is, it's right there in the folder.

@SirTell
Copy link

SirTell commented Jun 27, 2018

I have also problem. If I start the C:\flameshot\flameshot.exe
It says can't find Qt5Cored.dll, psl try to reinstall the software.

I hope you can fix this I love this app in Linux.

I try to copy Qt5Cored.dll to C:\Windows\SysWOW64 or/and C:\Windows\System32
is helps nothing

@balthild
Copy link

Is it able to compile/run on macOS now?

@holazt
Copy link
Member Author

holazt commented Jul 27, 2018

@balthild Not yet. However, we are working in process.

@limonte
Copy link

limonte commented Aug 28, 2018

You can get the links to test the application from AppVeyor builds:

@fmaiabatista
Copy link

fmaiabatista commented Sep 22, 2018

I'm somewhat newbie on building Linux applications and I'd like to try Flameshot on Windows.

Could you guys provide a dummy-proof step-by-step guide to do it?

I just loved the app and now I'm willing to ditch my current Windows screenshot app for Flameshot!

Edit: Links above not working.

@ipenev92
Copy link

ipenev92 commented Sep 26, 2018

You can get the links to test the application from AppVeyor builds:

Just me, or neither of the links is working?

@Lenart12
Copy link

They are not working for me either

@TuxGamer
Copy link

@Lenart12 @ipenev92 You can find the latest link by going to the AppVeyor builds page, clicking on your paltform (amd64 = 64-bit, x86 = 32-bit), scrolling down the console and going to the transfer.sh link at the very bottom of the page.

As of now, these are the latest builds:

@SlinkySlonkyOlivia
Copy link

Using those links gave me a version that works! that's great to be honest. (AssAsIN10556 here, got new account)

@xcme
Copy link

xcme commented Nov 25, 2018

Do I understand correctly these windbows builds are unofficial? I download and started 0.6.0 and it works. I really need this tools under windows because it's best tool I seen. :)

@SlinkySlonkyOlivia
Copy link

Today i noticed a bug where i'm only able to take a screenshot on my main screen. My laptop screen is not affected by flameshot anyomore and clicking in that screen exits Flameshot. I have no clue how this happened since i haven't changed any settings since i installed it.

@holazt
Copy link
Member Author

holazt commented Nov 27, 2018

@xcme Currently, these windows building are official, but it still has some unkown bugs, it's unstable.

@Metadorius
Copy link

AppVeyor builds give 404. :\

@TuxGamer
Copy link

@Metadorius Go to https://ci.appveyor.com/project/lupoDharkael/flameshot , select your platform (32 or 64 bit) and search for "curl --upload-file". It prints the download link slightly below that.

As of today, the links are:

@SlinkySlonkyOlivia
Copy link

@Metadorius Go to https://ci.appveyor.com/project/lupoDharkael/flameshot , select your platform (32 or 64 bit) and search for "curl --upload-file". It prints the download link slightly below that.

As of today, the links are:

* https://transfer.sh/sKEDg/flameshot_0.6.0_win_X64.zip (64 bit)

* https://transfer.sh/5c4aE/flameshot_0.6.0_win_x86.zip (32 bit)

Hey, uh
None of these links work anymore, the only text that appears in the webpage is "Not found"...

@Mackzwellz
Copy link

For those who still don't get it (as I did at first), here's a few screenshots that explain how to get the link for the latest build:
https://imgur.com/a/90DK6yU

@4sStylZ
Copy link

4sStylZ commented Dec 4, 2019

Thank you for the imgur gruide.

The build seem's broken…

NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\cl.EXE"' : return code '0x2'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\BIN\amd64\nmake.exe"' : return code '0x2'
Stop.
Command exited with code 2

@Mackzwellz
Copy link

You can try to find the most recent successful build on History tab.
For now it's this one: https://ci.appveyor.com/project/lupoDharkael/flameshot/builds/29235281

@4sStylZ
Copy link

4sStylZ commented Dec 5, 2019

Thank you.

@elie-g
Copy link

elie-g commented Dec 5, 2019

Steps to download the latest windows version of Flameshot:

  1. Go to the Flameshot's build history page in AppVeyor
  2. Select the latest successful build
    Build history
  3. Select the job corresponding to your platform
    Jobs
  4. Scroll down to the end of the logs and find the link to the zip archive
    Logs

Note: files on transfer.sh are only kept for 14 days, so builds older than 14 days cannot therefore be downloaded.

@Lysak
Copy link

Lysak commented Jan 11, 2020

Steps to download the latest windows version of Flameshot:

  1. Go to the Flameshot's build history page in AppVeyor
  2. Select the latest successful build
    Build history
  3. Select the job corresponding to your platform
    Jobs
  4. Scroll down to the end of the logs and find the link to the zip archive
    Logs

when open link -- Not Found

@elie-g
Copy link

elie-g commented Jan 14, 2020

@Lysak transfer.sh only keeps files for 14 days, so if the build is older than 14 days, you won't be able to download it.

@holazt
Copy link
Member Author

holazt commented Jan 14, 2020

@Lysak You can download Windows binary from the latest pull request.
image

@djalmajr
Copy link

Same with me... This build has only 11 hours, but I get "Not Found" yet. Am I missing something?

image

image

https://transfer.sh/2Yn8e/flameshot_0.6.0_win_X64.zip

@xcme
Copy link

xcme commented Jan 31, 2020

It seems there is no more updates for last 1,5 years. Should we forget about stable official release for Windows?

@InventM4n
Copy link

I can download it just now, yesterday I couldn't

I let you a mirror here http://www.mediafire.com/file/37ea95nff127297/flameshot_0.6.0_win_X64.zip/file

@djalmajr
Copy link

djalmajr commented Feb 2, 2020

Thanks a lot!

@djalmajr
Copy link

djalmajr commented Feb 4, 2020

This app is awesome! Thanks...

Just one more question: there is a way to add arguments to flameshot run a screen capture on Windows? 😁 I have tried to run flameshot.exe gui but doesn't work... flameshot.exe works though and the app shows in the tray system.

@Mackzwellz Mackzwellz mentioned this issue Apr 4, 2020
@oyhel
Copy link

oyhel commented May 13, 2020

Did you ever find a way to call flameshot.exe gui from Windows 10? This tool is very useful, but having to click the button in the tray makes it a bit of a hassle to use.

@DniweTamp
Copy link

latest release uses printscreen button to open the gui

@borgmanJeremy
Copy link
Contributor

I opened #861 so that we will officially host the binaries on github after the next release. If there are still specific bugs after the next release lets file new reports.

@lucidBrot
Copy link

lucidBrot commented Nov 30, 2020

latest release uses printscreen button to open the gui
- @DniweTamp

Is there a way do specify the shortcut (on Windows)? I'd like to use WinPrntScrn because PrntScrn is already mapped for a different program.

@shiftgeist
Copy link

@lucidBrot You can use AutoHotkey. To my knowledge there is no option to change the shortcut in flameshot, is there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Feature requests and code enhancements
Projects
None yet
Development

No branches or pull requests