Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backtest-build-block relies on coinbase_secret_key which is not set in backtest-config #138

Open
bertmiller opened this issue Aug 21, 2024 · 1 comment · May be fixed by #215
Open

backtest-build-block relies on coinbase_secret_key which is not set in backtest-config #138

bertmiller opened this issue Aug 21, 2024 · 1 comment · May be fixed by #215
Labels
A-backtest Focuses on the backtest tooling bug Something isn't working

Comments

@bertmiller
Copy link
Member

As per the title, when running backtest-build-block we rely on having a coinbase signer here: https://github.com/flashbots/rbuilder/blob/develop/crates/rbuilder/src/backtest/backtest_build_block.rs#L112

Which ultimately needs a coinbase_secret_key being set to derive that from:
https://github.com/flashbots/rbuilder/blob/develop/crates/rbuilder/src/live_builder/base_config.rs#L225

But it's not present in backtesting. That means that with the example backtesting config we throw an error when trying to get the coinbase signer as an input to build the block.

If we're backtesting and there is no key set, we could generate a random one as a simple fix.

@ferranbt ferranbt added bug Something isn't working A-backtest Focuses on the backtest tooling labels Aug 21, 2024
@0xmichalis
Copy link
Contributor

0xmichalis commented Dec 11, 2024

@bertmiller @ferranbt it'd be great to get #215 merged as currently the noob guide to backtesting is broken without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backtest Focuses on the backtest tooling bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants