This repository has been archived by the owner on Apr 25, 2022. It is now read-only.
Implement beta handling #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
razzeee
force-pushed
the
add-beta-handling
branch
6 times, most recently
from
ef4a107
to
4518dfa
Compare
razzeee
force-pushed
the
add-beta-handling
branch
from
e242741
to
2017019
Compare
razzeee
force-pushed
the
add-beta-handling
branch
from
2017019
to
c6f43c3
Compare
| const CmdInstructions = ({ appId }: { appId: string }) => { | ||
| const CmdInstructions = ({ | ||
| appId, | ||
| isStable, |
There was a problem hiding this comment.
Can't this be an enum with Stable/Beta items, that represents the "Branch"? Who knows maybe at some point there would be a "nightly" thing or whatever
There was a problem hiding this comment.
It sure can, but changing that shouldn't be a problem at that point. This only designs for what we need right now, I fear scope creep otherwise.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.