-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash when url is data URI #561
Comments
I can't reproduce in git master:
I did find a related error though: #562 |
Turns out |
See also: #563 |
I think this is fixed considering above is merged, closing. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
flatpak-builder version
1.3.3
Flatpak version
Flatpak 1.15.4
How to reproduce
flatpak-builder build --force-clean test.json
Expected Behavior
It shouldn't crash. It should print out that
data:
is not supported and exit.Actual Behavior
Crashes
Additional Information
The invalid url is being generated by https://github.com/flatpak/flatpak-builder-tools/blob/30db60f6a086ed0457b774cc0dc7fa11b9045fcf/npm/flatpak-npm-generator.py#L189 due to it being obsolete. But still I don't think builder should crash here.
The text was updated successfully, but these errors were encountered: