feat: add UI support for flag metadata #3717
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
- Add IFlagMetadata interface to Flag.ts - Create MetadataForm component with CRUD operations - Add validation using Yup schema - Use Radix UI components for accessibility - Style with TailwindCSS - Install required type declarations Co-Authored-By: Mark Phelps <mark@flipt.io>
- Add metadata field to flag form - Update validation schema for metadata - Follow existing styling patterns - Add proper TypeScript types Co-Authored-By: Mark Phelps <mark@flipt.io>
- Ensure metadata is preserved in updateFlag mutation - Preserve metadata when copying flags - Add proper TypeScript types for metadata handling Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io> Signed-off-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Co-Authored-By: Mark Phelps <mark@flipt.io>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
|
The object could be included in the metadata. This is an example what people have https://discord.com/channels/960634591000014878/1309109822657921034/1309120286142107668. |
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3717 +/- ##
=======================================
Coverage 64.55% 64.55%
=======================================
Files 170 170
Lines 17163 17163
=======================================
Hits 11079 11079
Misses 5393 5393
Partials 691 691
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Signed-off-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
im updating it to support nested objects and other types such as arrays |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements UI components for flag metadata CRUD operations.
Closes #2682
Link to Devin run: https://app.devin.ai/sessions/d62abd8bc3cb467dba175d847f5b8f07
Metadata entries can be of type
primitive, array, or object.If array or object we render the JSONEditor.
If primitive the user selects a subtype of 'string, number, or boolean'
TODO