Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group holiday tests into folders #341

Open
XSpielinbox opened this issue Sep 27, 2023 · 0 comments
Open

Group holiday tests into folders #341

XSpielinbox opened this issue Sep 27, 2023 · 0 comments
Labels
status: new Initial state for every issue / pull request topic: testing

Comments

@XSpielinbox
Copy link
Contributor

More information

We are starting to approach a very large amount of holiday test files in the jollyday-tests/src/test/resources/holidays folder. To encourage people to create more such test files and allow for better overview it would be necessary in my opinion to move and sort them into sub-folders.

There the question arises:

  1. Make one folder for each country and have all years of the country in that folder or
  2. Make one folder for each year and have all countries for that year in that folder?

Whatever parameter is already in the folder name should not get duplicated into the file name in my opinion.

@XSpielinbox XSpielinbox added the status: new Initial state for every issue / pull request label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: new Initial state for every issue / pull request topic: testing
Projects
None yet
Development

No branches or pull requests

2 participants