Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naefels Trip is wrong if 'Holy Week' is in the same week #657

Open
derTobsch opened this issue Oct 30, 2024 · 0 comments
Open

Naefels Trip is wrong if 'Holy Week' is in the same week #657

derTobsch opened this issue Oct 30, 2024 · 0 comments
Labels
country: switzerland status: new Initial state for every issue / pull request topic: public holiday type: bug Something isn't working

Comments

@derTobsch
Copy link
Contributor

Affected country

Switzerland Glarus

Affected public holiday

Naefels Trip

Source of the information

https://www.ferienwiki.ch/feiertage/naefelser-fahrt

More information

see #635

At the moment, “Naefels Trip” is calculated as the first Thursday of April. This is incorrect, not 100% correct. If it falls within “Karwoche” (“Holy Week”). In that case, it would be on the second Thursday of April.

You could reuse “FindWeekDayInMonth” but check if the date falls between (Easter - 7 days) and Easter. If that is the case, you could just add 7 days.

@derTobsch derTobsch added type: bug Something isn't working topic: public holiday status: new Initial state for every issue / pull request country: switzerland labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
country: switzerland status: new Initial state for every issue / pull request topic: public holiday type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant