Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: vim.lsp.util.make_position_params() requires position/offset encoding on Nighly #606

Open
4 tasks done
lithammer opened this issue Nov 28, 2024 · 0 comments
Open
4 tasks done
Labels
bug Something isn't working

Comments

@lithammer
Copy link

Did you check docs and existing issues?

  • I have read all the trouble.nvim docs
  • I have updated the plugin to the latest version before submitting this issue
  • I have searched the existing issues of trouble.nvim
  • I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)

v0.11.0-dev-1247+g5897994cb7

Operating system/version

Debian Trixie

Describe the bug

On nightly, vim.lsp.util.make_position_params() requires a second argument position_encoding. Otherwise it generates this warning message:

position_encoding param is required in vim.lsp.util.make_position_params. Defaulting to position encoding of the first client.

local params = opts.params or vim.lsp.util.make_position_params(win)

Upstream change: neovim/neovim#31249

I guess client and/or client.offset_encoding has to be propagated.

Steps To Reproduce

  1. Open some buffer that attaches a language server.
  2. Run :Trouble lsp_implementations on some identifier.

Expected Behavior

Expect no warning.

Repro

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant