Deleting disabled cell – bad update for indirectly disabled cells and scope

[fonsp]

One cell defines x and is disabled, and another cell contains x + 1 (indirectly disabled). When I remove the first cell, the second cell remains indirectly disabled.

The variable x also remains in scope! That's not good

In this video I was not able to reproduce the cell remaining disabled indirectly, but xx stayed in scope:

Schermopname.2024-11-07.om.14.46.47.mov

[fonsp]

The bug is probably in this file:

Pluto.jl/src/evaluation/Run.jl

Lines 78 to 91 in 313a0f4

	removed_cells = setdiff(all_cells(old_topology), all_cells(new_topology))
	roots = vcat(roots, removed_cells)
	# by setting the reactive node and expression caches of deleted cells to "empty", we are essentially pretending that those cells still exist, but now have empty code. this makes our algorithm simpler.
	new_topology = PlutoDependencyExplorer.exclude_roots(new_topology, removed_cells)
	# find (indirectly) deactivated cells and update their status
	indirectly_deactivated = collect(topological_order(new_topology, collect(new_topology.disabled_cells); allow_multiple_defs=true, skip_at_partial_multiple_defs=true))
	for cell in indirectly_deactivated
	cell.running = false
	cell.queued = false
	cell.depends_on_disabled_cells = true
	end

And you can add a test here:

https://github.com/fonsp/Pluto.jl/blob/main/test/cell_disabling.jl

You can delete a cell in these tests by modifying both notebook.cells_dict and notebook.cell_order.