Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update unit tests to test helper functions not the Intl APIs #51

Open
ericf opened this issue Oct 7, 2014 · 0 comments
Open

Update unit tests to test helper functions not the Intl APIs #51

ericf opened this issue Oct 7, 2014 · 0 comments

Comments

@ericf
Copy link
Collaborator

ericf commented Oct 7, 2014

The current unit tests basically test the Intl APIs to death, but the Intl APIs should be mocked and we shouldn't worry about them much at this level. Instead, the unit tests for this package should be focused on the functions it adds, and to make sure it's calling into the Intl APIs correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericf