-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
not rendering as expected in newer versions of this library? #464
Comments
Same with version 11.1.1 |
UPD here - issue is related to dependency cheerio. A few weeks ago author published version 1.0.0 after previous 1.0.0-rc.12 and now because dependency is written like
The new version is being installed. If you want to have a quick fix - install version 1.0.0-rc.12 next to the email-templates package in root package.json , or you also can play with "overrides" or "resolutions" in package.json depending on what you are using - yarn or npm |
Have a problem that seems to be related, previously working link with & started to appear in templates like |
Another workaround is to disable juice (set |
@titanism is it possible Cheerio can be added as a dep and republish on NPM please? |
Node.js version:
20.0.0
OS version:
macOS 14.3.1
Description:
  ; doesn't appear to be rendering "correctly" as a space character with pug templates. Instead it renders as "  ;". This appears to work as I would expect in version 6.0.0 of this library but upon updating recently to 12.0.0, it is no longer working as it used to.
Please note: I have inserted an extra space before the semi-colon of the "  ;" inside this ticket because GitHub actually renders it as the non breaking space character.
Actual behavior:
  ; renders as as "  ;" when using it inside pug templates. For example, if you have the following inside a pug template: "p(style='font-size: 12px;')   ;", in the actual rendered email you will see "  ;" instead of a space character.
Expected behavior:
  ; renders as as non-breaking space character.
Code to reproduce:
On version 12.0.0 (and perhaps other earlier versions outside of 6.0.0), render a pug template with the following: "p(style='font-size: 12px;')   ;" and send a test email. In the received email, you will see "  ;" instead of a space character in the rendered paragraph.
Thanks
The text was updated successfully, but these errors were encountered: