-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split flappy.svg into multiple files #108
Comments
I would like to solve this issue.
|
Sounds good to me. Please go ahead. |
I forgot to mention that I will place all those folders in one folder layers/ if that is ok |
If you do not modify flappy.svg but add flappy2.svg, and index2.svg, we can have several merges and people helping you on the gh-pages branch. |
Sure. |
OK I will not modify it then :) |
@Abhi2424shek Have a look here, what do you think? |
@niccokunzmann we could make the use of JavaScript as you mentioned. I think there is a JavaScript library for that, but we could easily do it without it too. Do you want me to open up my terminal :) |
This issue is important for our high-quality workflow^^. So, if you have some more suggestions of how to solve it, I would like to read your pull-requests. |
Give me some time I got a n exam tomorrow and it's the last and the most tough so I would do a PR after that can you give me that much if time plz. If yes expect a PR from me in 6 hours. |
@Abhi2424shek You have all the time you want and you do not need to do it. I wanted to point you here because you may like the challenge. |
I am on it then @niccokunzmann got this one. |
@niccokunzmann got a tidy fix but that would be a big change shall I go on, I would need to work arround maybe whole of the javascript in the site, so I taught I should ask your permission to submit a massive change on! |
Please commit the change to the flappy2.svg file. |
When all works, we just move it. |
I do not have much time today. |
@niccokunzmann I won't finish it today but it sure that I will learn a lot! |
…es. (#227) * Added my name to the credits.html file Done as part of GCI task: https://codein.withgoogle.com/dashboard/task-instances/6293522636341248/ I have added a PR which will merge into the master branch, this one on to the gh-pages branch. * Part I for Flappy SVG version 2 * Trick
…231) * Added my name to the credits.html file Done as part of GCI task: https://codein.withgoogle.com/dashboard/task-instances/6293522636341248/ I have added a PR which will merge into the master branch, this one on to the gh-pages branch. * Making layers visible individually and progressed splitting of flappySVG into multiple parts
Nope we need to fix the JavaScript as well @jayvdb since labels can no longer be used |
This is the progress. We have splitter the characters and backgrounds and made them to be embedded inside a particular page, now the JavaScript needs refraction, the major problem is that the label tag can no longer work instead we should use id's. The flappysvg2 is the effort. |
@niccokunzmann @abishekvashok what refractor are you speaking about? |
@harry-7 pls refer the code, we have successfully split the svg file into multiple svg files and included them in an html file. But the code would need some refractor, currently the indetifiers used has become nested and therefore those indetifiers parts need a refractor. |
Problem
Currently, all layers are in flappy.svg.
This causes the following problems:
Solution
Split the flappy.svg file into several files. SVGs can be embedded in SVGs, so no problem there.
Comment if you want to do this and please outline a plan on what your solution looks like. Change is hard once coding began, so the plan should be good first.
The text was updated successfully, but these errors were encountered: