Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of InstantCommand for cameras #143

Closed
willitcode opened this issue Mar 18, 2024 · 1 comment · Fixed by #153
Closed

Get rid of InstantCommand for cameras #143

willitcode opened this issue Mar 18, 2024 · 1 comment · Fixed by #153
Assignees
Labels
bug Something isn't working

Comments

@willitcode
Copy link
Member

I hate inline creation of commands, so bye bye!

Turn this into a fully-fledged command class. This should be abstracted such that we can make multiple StartCamera commands for multiple different cameras though, so we do need to break our "no dependency injection" rule here in order to make the command flexible enough to allow for multiple commands.

Putting camera numbers in Constants is also in scope for this issue (and should happen).

@willitcode willitcode added the bug Something isn't working label Mar 18, 2024
@willitcode
Copy link
Member Author

In do later because Heartland branch needs to get merged first

@AraReighard AraReighard self-assigned this Mar 19, 2024
@AraReighard AraReighard linked a pull request Mar 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants