Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression in past year with new promise? implementation #153

Open
bsless opened this issue May 9, 2024 · 0 comments
Open

Comments

@bsless
Copy link

bsless commented May 9, 2024

The new implementation for promise? uses satisfies? and is called on every unwrap.
In high throughput where lots of promises are created and chained, calls to satisfies? come to dominate the code's run time.
We had to either pin promesa versions or drop it at work due to this change.
It seems like an alternative solution could be making unwrap a protocol.
What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant