Merge branch 'master' into bump-up-v0.1.3

funzin · Aug 21, 2019 · 32dccb3 · 32dccb3
2 parents 9fe08e7 + 8ec9203
commit 32dccb3
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 8 deletions.
diff --git a/README.md b/README.md
@@ -22,7 +22,7 @@
 </p>
 
 ## Overview
-ImgConverter is chrome extension that converts form image of markdown notation to img tag(`<img>`) when you upload images to issue or Pull Request on Github.
+ImgConverter is chrome extension that converts form image of markdown notation to img tag(`<img>`) when you upload images
 
 - Chrome Extensions: [ImgConverter](https://chrome.google.com/webstore/detail/imgconverter-for-github/pkgimcoeodgcdfnidhgijpopkfhbcomm)
 
@@ -31,11 +31,17 @@ ImgConverter is chrome extension that converts form image of markdown notation t
 - JPEG (.jpg)
 
 ## Environment
-- javascript
+- Javascript
 - node(v12.1.0)
 - npm(v6.9.0)
 - karma(jasmine)
 
+## Confirmed services
+- Github
+- esa
+- Docbase
+
+etc.
 
 ## DEMO
 ![demo](resource/gif/demo.gif)

diff --git a/manifest.json b/manifest.json
@@ -1,5 +1,5 @@
 {
-  "name": "ImgConverter for Github",
+  "name": "ImgConverter",
   "short_name": "ImgConverter",
   "version": "0.1.3",
   "description": "ImgConverter converts from image of markdown notation to to img tag",

diff --git a/spec/js/convert-to-img-tag-spec.js b/spec/js/convert-to-img-tag-spec.js
@@ -6,25 +6,25 @@ describe("convertToImgTag", function(){
   describe('when text contains markdown image', function () {
     beforeEach(function () {
       text = "hogehoge![title](https://user-images.githubusercontent.com/test0.png)\n \
-              hogehoge![title](https://user-images.githubusercontent.com/test1.png)"
+              hogehoge![title](https://img.esa.io/uploads/production/pictures/image/test1.png)"
       result = convertToImgTag(text, "")
     })
     it('should return replaced text', function () {
       text = "hogehoge<img src=https://user-images.githubusercontent.com/test0.png >\n \
-              hogehoge<img src=https://user-images.githubusercontent.com/test1.png >"
+              hogehoge<img src=https://img.esa.io/uploads/production/pictures/image/test1.png >"
       expect(result).toEqual(text)
     })
   }) 
 
   describe('when image title contains space', function () {
     beforeEach(function () {
       text = "hogehoge![hello world](https://user-images.githubusercontent.com/test0.png)\n \
-              hogehoge![hello world](https://user-images.githubusercontent.com/test1.png)"
+              hogehoge![hello world](https://img.esa.io/uploads/production/pictures/image/test1.png)"
       result = convertToImgTag(text, "")
     })
     it('should return replaced text', function () {
       text = "hogehoge<img src=https://user-images.githubusercontent.com/test0.png >\n \
-              hogehoge<img src=https://user-images.githubusercontent.com/test1.png >"
+              hogehoge<img src=https://img.esa.io/uploads/production/pictures/image/test1.png >"
       expect(result).toEqual(text)
     })
   }) 

diff --git a/src/js/convert-to-img-tag.js b/src/js/convert-to-img-tag.js
@@ -30,7 +30,7 @@ function convertToImgTag(text, params) {
 
 function createMarkdownImages(text, params) {
   let markdownImageArray = []
-  const results = text.match(/\!\[.*\]\(https:\/\/user-images.githubusercontent.com\S+(jpg|jpeg|png)\)/gmi)
+  const results = text.match(/\!\[.*\]\(https:\/\/\S+(jpg|jpeg|png)\)/gmi)
   if (results == null) { return null}
 
   for (const mdImage of results) {