From 7ad40ba3680a4f3492e9dbd91432ac093759c450 Mon Sep 17 00:00:00 2001 From: Max Horn Date: Wed, 26 Jul 2023 16:10:15 +0200 Subject: [PATCH] Remove unused SetAsNiceMono --- archive/group2.gd | 2 -- archive/group2.gi | 11 ----------- doc/include/methods_inventory.txt | 2 -- doc/include/operations_inventory.txt | 2 -- lib/correlations.gd | 2 -- lib/correlations.gi | 11 ----------- lib/group.gd | 2 -- lib/group.gi | 20 -------------------- old/group2old.gd | 3 --- old/group2old.gi | 8 -------- 10 files changed, 63 deletions(-) diff --git a/archive/group2.gd b/archive/group2.gd index 93792329..600146ef 100644 --- a/archive/group2.gd +++ b/archive/group2.gd @@ -72,8 +72,6 @@ DeclareOperation( "ProjElWithFrobWithPSIsom", [IsMatrix and IsFFECollColl, IsMapping, IsField, IsGeneralMapping and IsSPGeneralMapping and IsOne] ); DeclareOperation( "ProjElsWithFrobWithPSIsom", [IsList, IsField] ); -DeclareOperation( "SetAsNiceMono", - [IsProjGroupWithFrobWithPSIsom, IsGroupHomomorphism] ); DeclareAttribute( "Dimension", IsProjGroupWithFrobWithPSIsom ); DeclareProperty( "CanComputeActionOnPoints", IsProjGroupWithFrobWithPSIsom ); DeclareOperation( "CorrelationOfProjectiveSpace", [ IsList, IsField] ); diff --git a/archive/group2.gi b/archive/group2.gi index 3c98e03b..f7a1945d 100644 --- a/archive/group2.gi +++ b/archive/group2.gi @@ -1084,17 +1084,6 @@ InstallMethod( CanComputeActionOnPoints, fi; end ); -## A grep of SetAsNiceMono on all *.gi files gives only the InstallMethod( parts. (jdb 20/9/11), see also comment in -## group.gi - -InstallMethod( SetAsNiceMono, - "for a projective group with Frobenius with pspace isomorphism and an action hom", - [IsProjGroupWithFrobWithPSIsom, IsGroupHomomorphism and IsInjective], - function( pg, a ) - SetNiceMonomorphism(pg,a); - SetNiceObject(pg,Image(a)); - end ); - # CHECKED 20/09/11 jdb ############################################################################# #O NiceMonomorphism( ) diff --git a/doc/include/methods_inventory.txt b/doc/include/methods_inventory.txt index faee7342..20fb1537 100644 --- a/doc/include/methods_inventory.txt +++ b/doc/include/methods_inventory.txt @@ -223,7 +223,6 @@ M: Dimension, [IsProjectiveGroupWithFrob], M: OneImmutable, # was [IsGroup and IsProjectiveGroupWithFrob], I think might be M: CanComputeActionOnPoints, [IsProjectiveGroupWithFrob], M: ActionOnAllProjPoints, [ IsProjectiveGroupWithFrob ], -M: SetAsNiceMono, [IsProjectiveGroupWithFrob, IsGroupHomomorphism and IsInjective], M: NiceMonomorphism, [IsProjectivityGroup and CanComputeActionOnPoints and IsHandledByNiceMonomorphism], M: NiceMonomorphism, [IsProjectiveGroupWithFrob and IsHandledByNiceMonomorphism], M: NiceMonomorphism, [IsProjectiveGroupWithFrob and CanComputeActionOnPoints and IsHandledByNiceMonomorphism], 1, @@ -417,7 +416,6 @@ M: Embedding, [IsProjectiveGroupWithFrob, IsProjGroupWithFrobWithPSIsom], M: Dimension, [IsProjGroupWithFrobWithPSIsom], M: ActionOnAllPointsHyperplanes, [ IsProjGroupWithFrobWithPSIsom ], M: CanComputeActionOnPoints, [IsProjGroupWithFrobWithPSIsom], -M: SetAsNiceMono, [IsProjGroupWithFrobWithPSIsom, IsGroupHomomorphism and IsInjective], M: NiceMonomorphism, [IsProjGroupWithFrobWithPSIsom and CanComputeActionOnPoints and IsHandledByNiceMonomorphism], 50, M: NiceMonomorphism, [IsProjGroupWithFrobWithPSIsom and IsHandledByNiceMonomorphism], 50, M: ViewObj, [IsProjGroupWithFrobWithPSIsom], diff --git a/doc/include/operations_inventory.txt b/doc/include/operations_inventory.txt index b4616419..8f2f480e 100644 --- a/doc/include/operations_inventory.txt +++ b/doc/include/operations_inventory.txt @@ -110,7 +110,6 @@ O: MatrixOfCollineation: [IsProjGrpElWithFrobandIsProjGrpElWithFrobRep] O: MatrixOfCollineation: [IsProjGrpElandIsProjGrpElRep] O: FieldAutomorphism: [IsProjGrpElWithFrobandIsProjGrpElWithFrobRep] O: ActionOnAllProjPoints: [IsProjectiveGroupWithFrob] -O: SetAsNiceMono: [IsProjectiveGroupWithFrob, IsGroupHomomorphism] O: CanonicalGramMatrix: [IsString, IsPosInt, IsField] O: CanonicalQuadraticForm: [IsString, IsPosInt, IsField] O: SOdesargues: [IsInt, IsPosInt, IsFieldandIsFinite] @@ -168,7 +167,6 @@ O: ProjElWithFrobWithPSIsom: [IsMatrix and IsFFECollColl, IsMapping, IsFiel O: ProjElWithFrobWithPSIsom: [IsMatrix and IsFFECollColl, IsMapping, IsField, IsStandardDualityOfProjectiveSpace] O: ProjElWithFrobWithPSIsom: [IsMatrix and IsFFECollColl, IsMapping, IsField, IsGeneralMapping and IsSPGeneralMapping and IsOne] O: ProjElsWithFrobWithPSIsom: [IsList, IsField] -O: SetAsNiceMono: [IsProjGroupWithFrobWithPSIsom, IsGroupHomomorphism] O: CorrelationOfProjectiveSpace: [IsList, IsField] O: CorrelationOfProjectiveSpace: [IsList, IsMapping, IsField] O: CorrelationOfProjectiveSpace: [IsList, IsField, IsStandardDualityOfProjectiveSpace] diff --git a/lib/correlations.gd b/lib/correlations.gd index 05e67fd7..bc69581c 100644 --- a/lib/correlations.gd +++ b/lib/correlations.gd @@ -74,8 +74,6 @@ DeclareOperation( "ProjElWithFrobWithPSIsom", [IsMatrix and IsFFECollColl, IsMapping, IsField, IsGeneralMapping and IsSPGeneralMapping and IsOne] ); DeclareOperation( "ProjElsWithFrobWithPSIsom", [IsList, IsField] ); -DeclareOperation( "SetAsNiceMono", - [IsProjGroupWithFrobWithPSIsom, IsGroupHomomorphism] ); DeclareAttribute( "Dimension", IsProjGroupWithFrobWithPSIsom ); DeclareProperty( "CanComputeActionOnPoints", IsProjGroupWithFrobWithPSIsom ); diff --git a/lib/correlations.gi b/lib/correlations.gi index d2e6980d..e318b239 100644 --- a/lib/correlations.gi +++ b/lib/correlations.gi @@ -1425,17 +1425,6 @@ InstallMethod( CanComputeActionOnPoints, fi; end ); -## A grep of SetAsNiceMono on all *.gi files gives only the InstallMethod( parts. (jdb 20/9/11), see also comment in -## group.gi - -InstallMethod( SetAsNiceMono, - "for a projective group with Frobenius with pspace isomorphism and an action hom", - [IsProjGroupWithFrobWithPSIsom, IsGroupHomomorphism and IsInjective], - function( pg, a ) - SetNiceMonomorphism(pg,a); - SetNiceObject(pg,Image(a)); - end ); - # CHECKED 20/09/11 jdb ############################################################################# #O NiceMonomorphism( ) diff --git a/lib/group.gd b/lib/group.gd index 6ed36003..8fac25ec 100644 --- a/lib/group.gd +++ b/lib/group.gd @@ -132,7 +132,6 @@ DeclareGlobalFunction( "OnProjSubspacesNoFrob" ); # as a projective semilinear group (i.e. a collineation group), and for these # groups we have the operations defined (ml 05/11/2012) #DeclareOperation( "ActionOnAllProjPoints", [IsProjectivityGroup] ); -#DeclareOperation( "SetAsNiceMono", [IsProjectivityGroup, IsGroupHomomorphism] ); #DeclareAttribute( "Dimension", IsProjectivityGroup ); #DeclareProperty( "CanComputeActionOnPoints", IsProjectivityGroup ); @@ -158,7 +157,6 @@ DeclareGlobalFunction( "OnProjPointsWithFrob" ); DeclareGlobalFunction( "OnProjSubspacesWithFrob" ); DeclareOperation( "ActionOnAllProjPoints", [IsProjectiveGroupWithFrob] ); -DeclareOperation( "SetAsNiceMono", [IsProjectiveGroupWithFrob, IsGroupHomomorphism] ); DeclareAttribute( "Dimension", IsProjectiveGroupWithFrob ); DeclareProperty( "CanComputeActionOnPoints", IsProjectiveGroupWithFrob ); diff --git a/lib/group.gi b/lib/group.gi index dbe5f159..61989f10 100644 --- a/lib/group.gi +++ b/lib/group.gi @@ -2154,26 +2154,6 @@ InstallGlobalFunction( NiceMonomorphismByDomain, return iso; end ); -## Is this operation ever used? I think it obselete (JB: 26/09/08) -## John is probably right. A grep of SetAsNiceMono on all *.gi files gives only the InstallMethod( parts. (jdb 6/9/11). - -# ml 07/11/2012: I have taken out the view, print and display methods -# for projectivity groups, since these are also collineation groups in FinInG -#InstallMethod( SetAsNiceMono, "for a projective group and an action hom", -# [IsProjectivityGroup, IsGroupHomomorphism and IsInjective], -# function( pg, a ) -# SetNiceMonomorphism(pg,a); -# SetNiceObject(pg,Image(a)); -# end ); - -InstallMethod( SetAsNiceMono, - "for a projective collineation group and an action hom", - [IsProjectiveGroupWithFrob, IsGroupHomomorphism and IsInjective], - function( pg, a ) - SetNiceMonomorphism(pg,a); - SetNiceObject(pg,Image(a)); - end ); - # CHECKED 6/09/11 jdb # cvec change 19/3/14 ############################################################################# diff --git a/old/group2old.gd b/old/group2old.gd index 2b04cec7..0e1991df 100644 --- a/old/group2old.gd +++ b/old/group2old.gd @@ -44,8 +44,5 @@ DeclareOperation( "ProjElWithFrobWithVSIsom", DeclareOperation( "ProjElsWithFrobWithVSIsom", [IsList, IsField] ); -DeclareOperation( "SetAsNiceMono", - [IsProjGroupWithFrobWithVSIsom, IsGroupHomomorphism] ); - DeclareAttribute( "Dimension", IsProjGroupWithFrobWithVSIsom ); DeclareProperty( "CanComputeActionOnPoints", IsProjGroupWithFrobWithVSIsom ); diff --git a/old/group2old.gi b/old/group2old.gi index ef8c1c2f..f625d21f 100644 --- a/old/group2old.gi +++ b/old/group2old.gi @@ -530,14 +530,6 @@ InstallMethod( ActionOnPointsHyperplanes, return a; end ); -#InstallMethod( SetAsNiceMono, -# "for a projective group with Frobenius with vspace isomorphism and an action hom", -# [IsProjGroupWithFrobWithVSIsom, IsGroupHomomorphism and IsInjective], -# function( pg, a ) -# SetNiceMonomorphism(pg,a); -# SetNiceObject(pg,Image(a)); -# end ); - #InstallMethod( NiceMonomorphism, # "for a projective group with Frobenius with vspace isomorphism (feasible case)", # [IsProjGroupWithFrobWithVSIsom and CanComputeActionOnPoints and