Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depth-first Search (DFS) #45

Open
FriedrichRober opened this issue Sep 28, 2022 · 1 comment · May be fixed by #47
Open

Depth-first Search (DFS) #45

FriedrichRober opened this issue Sep 28, 2022 · 1 comment · May be fixed by #47
Labels
enhancement New feature or request

Comments

@FriedrichRober
Copy link
Collaborator

FriedrichRober commented Sep 28, 2022

The current methods use a Breadth-first Search (BFS) method for going through the lattice of normal subgroups. For some applications, like finding a normal subgroup of a specific index, we should be a lot faster and get to a much higher index with using DFS.

Things to note:

  • We need to keep track of which quotients we have searched for, T- and P-Quotients alike.
  • We need to take intersections with all groups in each step, not just the ones at higher levels.
@FriedrichRober FriedrichRober added the enhancement New feature or request label Sep 28, 2022
@FriedrichRober FriedrichRober linked a pull request Oct 7, 2022 that will close this issue
@FriedrichRober
Copy link
Collaborator Author

We should add an option, that can select the next subgroup to consider (This way, we could also implement DFS).

For example, if we search for a subgroup of index 15, it might be usefull to first try to find a subgroup of index 3 under G, and next one of index 5 under G. Then the intersection will have index 15.

Otherwise DFS will first compute all subgroups of index 3, before finding the one of 5 under G.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant