Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Kraken testGettingMinOrderVolumeIfAvailable() unit test #171

Open
gazbert opened this issue Nov 14, 2024 · 0 comments
Open

Fix Kraken testGettingMinOrderVolumeIfAvailable() unit test #171

gazbert opened this issue Nov 14, 2024 · 0 comments

Comments

@gazbert
Copy link
Owner

gazbert commented Nov 14, 2024

The test makes an actual call to the exchange to get the values used in the test assertions - too brittle!

Test to fix:
https://github.com/gazbert/bxbot/blob/3733bcb187c29365f74d6621f2ce2dbc287fddee/bxbot-exchanges/src/test/java/com/gazbert/bxbot/exchanges/TestKrakenExchangeAdapter.java#L1105C15-L1105C51

Patched:
f9a2a4a#diff-e4b2fe7ddebc9096854b04778f49ad546020a701b4a6268d000c2f40bdcd6e70

Change test so that it mocks out the network call.

@gazbert gazbert added this to BX-bot Nov 14, 2024
@gazbert gazbert changed the title Fix Kraken TestPairPrecisionConfigImpl unit test Fix Kraken Exchange Adapter unit test Nov 14, 2024
@gazbert gazbert changed the title Fix Kraken Exchange Adapter unit test Fix Kraken Exchange Adapter getMinimumOrderVolume() unit test Nov 14, 2024
@gazbert gazbert changed the title Fix Kraken Exchange Adapter getMinimumOrderVolume() unit test Fix Kraken Exchange Adapter testGettingMinOrderVolumeIfAvailable() unit test Nov 14, 2024
@gazbert gazbert changed the title Fix Kraken Exchange Adapter testGettingMinOrderVolumeIfAvailable() unit test Fix Kraken Exchange Adapter unit test Nov 14, 2024
@gazbert gazbert changed the title Fix Kraken Exchange Adapter unit test Fix Kraken testGettingMinOrderVolumeIfAvailable() unit test Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ToDo
Development

No branches or pull requests

1 participant