Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version requirement on urdfdom so it works with version 4.0 #1350

Open
azeey opened this issue Dec 1, 2023 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@azeey
Copy link
Collaborator

azeey commented Dec 1, 2023

Environment

  • OS Version: Ubuntu 22.04
  • Source or binary build? sdf12

Description

ros/urdfdom#186 is updating urdfdom to 4.0 and making the find_package logic more strict about version numbers. It's not clear if it will break sdformat since

ign_find_package(IgnURDFDOM VERSION 1.0 QUIET)

requires anything newer than 1.0. But the change in ros/urdfdom#186 might make it so it only finds versions with the same major version.

Things to try

  • Just remove the VERSION 1.0 and see if it works since liburdfdom versions in all platforms we support is newer than 1.0
  • Add logic that also looks for 4.0
@azeey azeey added the bug Something isn't working label Dec 1, 2023
@azeey azeey self-assigned this Jan 8, 2024
@azeey azeey moved this from Inbox to To do in Core development Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To do
Development

No branches or pull requests

1 participant