Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message only overflows at 74 #67

Closed
MithicSpirit opened this issue May 28, 2024 · 2 comments
Closed

Message only overflows at 74 #67

MithicSpirit opened this issue May 28, 2024 · 2 comments

Comments

@MithicSpirit
Copy link

The usual conventions are that messages overflow at 73 (72 is the maximum), but this parser only has them overflowing at 74. I suspect that the issue is due to the regex for SUMMARY allowing up to 72 characters but still being preceded by NOT_A_COMMENT, which includes an additional character. Additionally, note that while the subject line overflows at 51, SUBJECT only allows for 49 characters (presumably because it also is preceded by a NOT_A_COMMENT).

Since these appear to be the only places that NOT_A_COMMENT is used, I believe that it would make sense to remove it altogether and include the [^#] directly in SUMMARY and SUBJECT. Alternatively, there may be a way to have it check whether a # is present without consuming it, although I'm not familiar enough with tree-sitter to know.

@gbprod
Copy link
Owner

gbprod commented May 28, 2024

Hello @MithicSpirit !
Thanks for your feedback.
However, since the latests discussions here : #46 and https://www.reddit.com/r/neovim/comments/1cm5zir/question_should_i_commit_summaries_not_following/ I pretty sure that's I'll remove this feature soon (I'll explain the reasons later and I will give another way to do that easily).
So, I think you're right, there probably an issue here but I will not fix it 😅

@MithicSpirit
Copy link
Author

Fair enough

@MithicSpirit MithicSpirit closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants