Replace queue visibility timeout instance property

[patchwork01]

Background

There's an instance property sleeper.queue.visibility.timeout.seconds which sets the queue visibility timeout for a number of SQS queues. The property description is indirect about which queues it includes. It's not clear what the logic would be to set these timeouts on one instance property. In particular, some of the queues are consumed by lambdas without also setting lambda timeout.

Here are the queues currently configured by this:

• The standard ingest job queue
• The ingest batcher submission queue
• The query results queue

Description

We'd like to replace the queue visibility timeout instance property with separate properties to configure each of these queues appropriately.

Analysis

The ingest batcher submitter lambda has a property sleeper.ingest.batcher.submitter.timeout.seconds which sets the timeout for the lambda. The queue that triggers it probably needs a visibility timeout which matches that.

The standard ingest job queue visibility timeout needs to relate to the property sleeper.ingest.keepalive.period.seconds, which sets how often the message of a running ingest job has its visibility timeout reset. The description of the keepalive period property explains the relation to the queue visibility timeout, but the queue visibility timeout property doesn't mention it. We can make a property specific to standard ingest for its queue visibility timeout, which can also refer to the keepalive period property.

The query results queue doesn't relate to any of the other queues, as it is expected to be consumed by a client. It can be configured separately with its own property.