Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editing GO term of annotations with a NOT qualifier does not function properly #246

Open
krchristie opened this issue Oct 8, 2024 · 1 comment

Comments

@krchristie
Copy link

krchristie commented Oct 8, 2024

Similarly to the Standard Annotations editor ( geneontology/noctua-standard-annotations#55 ), @LiNiMGI noticed the same behavior in the Noctua-Form.

Here is the Noctua-Form editor with a NOT annotation shown fully expanded. Notice the contents of the RELATIONSHIP field: "NOT part of":
2024_10_07-editingNOTannot-OtherInfo-Form-1

Here is the new GO term I was entering in the editing field:
2024_10_07-editingNOTannot-OtherInfo-Form-2

Having edited the TERM field, notice that the contents of the RELATIONSHIP field is now only "part of" WITHOUT the "NOT":
2024_10_07-editingNOTannot-OtherInfo-Form-3

Clicking the "Save" button in the bar at the top commits the change still missing the "NOT" qualifier in the RELATIONSHIP field:
2024_10_07-editingNOTannot-OtherInfo-Form-4

Looking at the display of the same model in the Graph Editor suggests that the Noctua-Form editor has added the new GO term WITHOUT removing the original GO term and its associated "NOT" qualifier:
2024_10_07-editingNOTannot-OtherInfo-Form-5

The annotation Preview of this model suggests the same thing as the Graph Editor. Notice the 4th annotation in the table that has "involved_in|NOT" in the Qualifier field, but has the GO ID instead of the term name in the GO Term field:
2024_10_07-editingNOTannot-OtherInfo-Form-6

@vanaukenk
Copy link

vanaukenk commented Oct 29, 2024

@tmushayahama will investigate on the standard annotation editor (priority to fix there) if it's possible to edit when a NOT qualifier is involved.
(From a NOT to an UNNOT; from a NOT to a NOT; from an UNNOT to a NOT).

See: geneontology/noctua-standard-annotations#55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants