Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Refactor] unify keys drops/items #200

Open
devagja opened this issue Feb 24, 2023 · 1 comment
Open

[Bug][Refactor] unify keys drops/items #200

devagja opened this issue Feb 24, 2023 · 1 comment

Comments

@devagja
Copy link

devagja commented Feb 24, 2023

there are different keys for the same data type, It can be unified?

https://api.genshin.dev/domains/domain-of-guyun
rewards -> details ->

[
 {...
  drops: [
   { name: 'Lucky Dog', rarity: '2/3', drop_min: 0, drop_max: 1 },
  ]
 },
 {...
  items: [
   { name: 'Lucky Dog', rarity: 3, drop_min: 0, drop_max: 1 },
  ]
 }
]
@niktekusho
Copy link
Contributor

Another inconsistency could be found in the character API with how some properties are serialized to JSON (camel-case vs. snake-case).
From: https://api.genshin.dev/characters/yelan

image

Didn't check other APIs yet. I would love to open a PR to fix this, though. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants