-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
robots is not properly applied #42
Comments
I also noticed this and came here to report it. However, I subsequently realised that no sane crawler is going to index a page returning a 404 status, so the whole property is unnecessary. |
True, but I guess the fix won't hurt, will it? |
That is also true and at least it will be correct, but as a "less code" guy I'd rather lose it :/ |
I'd keep it. Otherwise someone will want to add it again in 3 years. It is clear and it is correct (in the PR). However it is a nice to know information, maybe we could add a comment? |
Ha! Fair enough, let's merge this. Easily overridden anyway. |
https://github.com/getgrav/grav-plugin-error/blame/develop/pages/error.md#L3
Does not work, and should be instead:
I found no reason why the first one should work, and it does not for me.
PR: #43
The text was updated successfully, but these errors were encountered: