Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robots is not properly applied #42

Open
NicoHood opened this issue Dec 10, 2020 · 5 comments
Open

robots is not properly applied #42

NicoHood opened this issue Dec 10, 2020 · 5 comments
Assignees

Comments

@NicoHood
Copy link

NicoHood commented Dec 10, 2020

https://github.com/getgrav/grav-plugin-error/blame/develop/pages/error.md#L3

robots: noindex,nofollow

Does not work, and should be instead:

metadata:
    robots: noindex,nofollow

I found no reason why the first one should work, and it does not for me.

PR: #43

NicoHood added a commit to NicoHood/grav-plugin-error that referenced this issue Dec 10, 2020
@mahagr mahagr assigned mahagr and rhukster and unassigned mahagr Dec 11, 2020
@hughbris
Copy link

I also noticed this and came here to report it. However, I subsequently realised that no sane crawler is going to index a page returning a 404 status, so the whole property is unnecessary.

@mahagr
Copy link
Member

mahagr commented Feb 14, 2022

True, but I guess the fix won't hurt, will it?

@hughbris
Copy link

That is also true and at least it will be correct, but as a "less code" guy I'd rather lose it :/

@NicoHood
Copy link
Author

I'd keep it. Otherwise someone will want to add it again in 3 years. It is clear and it is correct (in the PR). However it is a nice to know information, maybe we could add a comment?

@hughbris
Copy link

Otherwise someone will want to add it again in 3 years

Ha! Fair enough, let's merge this. Easily overridden anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants