Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox function is not working. #2

Open
pbt39ppc opened this issue May 15, 2016 · 8 comments
Open

Lightbox function is not working. #2

pbt39ppc opened this issue May 15, 2016 · 8 comments

Comments

@pbt39ppc
Copy link

pbt39ppc commented May 15, 2016

I get js error when clicking a image in modular _screenshots as follows:
Uncaught TypeError: Cannot read property 'opener' of null
The lightbox is stuck at loading and quitting the lightbox is not possible either.
All versions is straight from the skelleton and woo theme master. Very much worth a look!
Tested browsers is: Chrome v.50 ....
And some more error info:

Ca @ jquery-2.x.min.js:3
Fa @ jquery-2.x.min.js:3
n.extend.css @ jquery-2.x.min.js:3
V @ jquery-2.x.min.js:3
Za @ jquery-2.x.min.js:3
_a @ jquery-2.x.min.js:3
g @ jquery-2.x.min.js:3
n.extend.dequeue @ jquery-2.x.min.js:3
(anonymous function) @ jquery-2.x.min.js:3
n.extend.each @ jquery-2.x.min.js:2
n.fn.n.each @ jquery-2.x.min.js:2
n.fn.extend.queue @ jquery-2.x.min.js:3
n.fn.extend.animate @ jquery-2.x.min.js:3
quitLightbox @ imagelightbox.js:242
quitImageLightbox @ imagelightbox.js:307
(anonymous function) @ main.js:186
n.event.dispatch @ jquery-2.x.min.js:3
r.handle @ jquery-2.x.min.js:3

@pbt39ppc pbt39ppc changed the title Screenshots area dont working as expected. Lightbox function is not working. May 15, 2016
@flaviocopes
Copy link
Contributor

flaviocopes commented May 16, 2016

Can you replicate this on the demo http://demo.getgrav.org/woo-skeleton/? I could not, at a first glance.

@pbt39ppc
Copy link
Author

It was on the demo too.
Many times.
16 мая 2016 г. 10:50 пользователь "Flavio Copes" notifications@github.com
написал:

Can you replicate this on the demo? I could not, at a first glance.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#2 (comment)

@flaviocopes
Copy link
Contributor

On the homepage? I don't get it with Chrome. Which browser are you using?

Il giorno lun 16 mag 2016 alle 13:43 pbt39ppc notifications@github.com ha
scritto:

It was on the demo too.
Many times.
16 мая 2016 г. 10:50 пользователь "Flavio Copes" <notifications@github.com

написал:

Can you replicate this on the demo? I could not, at a first glance.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
<
https://github.com/getgrav/grav-theme-woo/issues/2#issuecomment-219368788>


You are receiving this because you commented.

Reply to this email directly or view it on GitHub
#2 (comment)

@pbt39ppc
Copy link
Author

i have check http://demo.getgrav.org/woo-skeleton/ now, seems today its working. (did you cange something?)
but when im uploading yesterday's zip atchive. then yes i can replicate it.
With chrome 50.0.2661.102 @ in Windows 7

@flaviocopes
Copy link
Contributor

Ok so now I can replicate it too, probably some timing-sensitive javascript thing

@flaviocopes
Copy link
Contributor

Now I cannot replicate it any more. Kind of elusive problem, happens sometimes, sometimes not

@hleen
Copy link

hleen commented May 20, 2016

Had that too on Xampp.
The solution was to replace system\assets\jquery\jquery-2.x.min.js by the last version of jQuery, jquery-2.2.3.min.js (renamed that file to jquery-2.x.min.js)

@flaviocopes
Copy link
Contributor

jQuery 2.2.4 is included in Grav 1.1, so when we release it and update the skeleton deploy the problem should go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants