Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log a warning when rate limiting is active #3817

Open
markushi opened this issue Oct 23, 2024 · 3 comments
Open

Log a warning when rate limiting is active #3817

markushi opened this issue Oct 23, 2024 · 3 comments

Comments

@markushi
Copy link
Member

markushi commented Oct 23, 2024

Description

Whe should log this as an warning instead of info:

options.getLogger().log(SentryLevel.INFO, "Envelope discarded due all items rate limited.");

@markushi
Copy link
Member Author

markushi commented Oct 23, 2024

Let's double check if we log warning in non-debug mode too (and check what other SDKs are doing).

@rwachtler
Copy link

Do you think it would also make sense to log a warning in case a single envelope item has been dropped due to rate-limiting? Similar to what has been suggested in here.

Regarding the handling of additional noise, sentry-cocoa has getsentry/sentry-cocoa#4467 , I assume that at some point that would be unified across SDKs.

@romtsn
Copy link
Member

romtsn commented Nov 5, 2024

@rwachtler yes it'd make sense, thanks for pointing that out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: Todo
Development

No branches or pull requests

3 participants