Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming instance_id to instance_index. #6778

Open
Tracked by #6762
Vecvec opened this issue Dec 18, 2024 · 0 comments · May be fixed by #6780
Open
Tracked by #6762

Consider renaming instance_id to instance_index. #6778

Vecvec opened this issue Dec 18, 2024 · 0 comments · May be fixed by #6780
Labels
api: dx12 Issues with DX12 or DXGI api: vulkan Issues with Vulkan area: naga front-end lang: WGSL WebGPU Shading Language naga Shader Translator type: enhancement New feature or request

Comments

@Vecvec
Copy link
Contributor

Vecvec commented Dec 18, 2024

Is your feature request related to a problem? Please describe.
instance_id is the index into the tlas package's instances member, however unlike most of the other indexes into things, this one is called *_id instead of *_index. This is likely because of instance_custom_index which is similar sounding, but it does not change any index so it's name is also confusing.

Describe the solution you'd like
We should rename instance_id to instance_index and instance_custom_index to instance_custom_data.

Describe alternatives you've considered
Not change their names.

Additional context
This currently matches the SPIRV spec (which is inconsistant with itself)

@cwfitzgerald cwfitzgerald added type: enhancement New feature or request api: dx12 Issues with DX12 or DXGI api: vulkan Issues with Vulkan naga Shader Translator area: naga front-end lang: WGSL WebGPU Shading Language labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: dx12 Issues with DX12 or DXGI api: vulkan Issues with Vulkan area: naga front-end lang: WGSL WebGPU Shading Language naga Shader Translator type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants