Consider renaming instance_id
to instance_index
.
#6778
Labels
api: dx12
Issues with DX12 or DXGI
api: vulkan
Issues with Vulkan
area: naga front-end
lang: WGSL
WebGPU Shading Language
naga
Shader Translator
type: enhancement
New feature or request
Is your feature request related to a problem? Please describe.
instance_id
is the index into the tlas package's instances member, however unlike most of the other indexes into things, this one is called*_id
instead of*_index
. This is likely because ofinstance_custom_index
which is similar sounding, but it does not change any index so it's name is also confusing.Describe the solution you'd like
We should rename
instance_id
toinstance_index
andinstance_custom_index
toinstance_custom_data
.Describe alternatives you've considered
Not change their names.
Additional context
This currently matches the SPIRV spec (which is inconsistant with itself)
The text was updated successfully, but these errors were encountered: