This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Adds healthz endpoint #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) count errors 2) healthz will response with http 500 error count is not 0
calvix
approved these changes
Dec 11, 2017
r7vme
pushed a commit
to giantswarm/kvm-operator
that referenced
this pull request
Dec 11, 2017
We need one to restart node-controller if it's stuck with broken tcp connections. Depend: giantswarm/kvm-operator-node-controller#10
r7vme
pushed a commit
to giantswarm/kvm-operator
that referenced
this pull request
Dec 11, 2017
We need one to restart node-controller if it's stuck with broken tcp connections. Depend: giantswarm/kvm-operator-node-controller#10
|
Since this is a rather ugly workaround I hope we can improve this later on. Is there some movement in your k8s-client issue? I would prefer getting the design right with the circuit breaker idea and create a new client to get new TCP connections on each reconciliation. |
|
there is a silence kubernetes/client-go#342 |
r7vme
pushed a commit
to giantswarm/kvm-operator
that referenced
this pull request
Dec 12, 2017
We need one to restart node-controller if it's stuck with broken tcp connections. Depend: giantswarm/kvm-operator-node-controller#10
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5
Tested, now node-controller restarted if master dies.